You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@guacamole.apache.org by Vieri <re...@yahoo.com.INVALID> on 2020/01/30 14:04:50 UTC
guac client logo
Hi,
This is probably a silly question, and I'm surely overlooking something.
I'm trying to replace the tab logo. I thought it would be enough to just create a manifest file with:
"resources" : {
"images/logo-64.png" : "image/png",
"images/logo-144.png" : "image/png"
}
and of course include those image files in a jar.
The extension loads, and I cleared my browser's cache.
However, the logo I see on the browser tab is the one shipped with Guacamole.
Vieri
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@guacamole.apache.org
For additional commands, e-mail: user-help@guacamole.apache.org
Re: guac client logo
Posted by Vieri <re...@yahoo.com.INVALID>.
On Thursday, January 30, 2020, 6:57:09 PM GMT+1, Mike Jumper <mj...@apache.org> wrote:
>
> you need to use the properties provided for doing that ("smallIcon" and "largeIcon").
Just so anyone else can get that right from the start, here's a sample of my manifest file:
{
"guacamoleVersion" : "*",
"name" : "mybrand",
"namespace" : "mybranding",
"translations" : [
"translations/en.json"
],
"css" : [
"css/login-override.css"
],
"html" : [
"WelcomeNotice.html"
],
"resources" : {
"images/logo-placeholder.png" : "image/png",
"images/guac-tricolor.png" : "image/png",
"images/logo-64.png" : "image/png",
"images/logo-144.png" : "image/png"
},
"smallIcon" : "images/logo-64.png",
"largeIcon" : "images/logo-144.png"
}
It works fine now, but I think I can safely remove the logo-{64,144}.png entries from "resources".
Once again, thanks!
Vieri
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@guacamole.apache.org
For additional commands, e-mail: user-help@guacamole.apache.org
Re: guac client logo
Posted by Mike Jumper <mj...@apache.org>.
On Thu, Jan 30, 2020, 06:05 Vieri <re...@yahoo.com.invalid> wrote:
> Hi,
>
> This is probably a silly question, and I'm surely overlooking something.
>
> I'm trying to replace the tab logo. I thought it would be enough to just
> create a manifest file with:
>
> "resources" : {
> "images/logo-64.png" : "image/png",
> "images/logo-144.png" : "image/png"
> }
>
> and of course include those image files in a jar.
> The extension loads, and I cleared my browser's cache.
> However, the logo I see on the browser tab is the one shipped with
> Guacamole.
The webapp (intentionally) does not allow extensions to directly replace
files which are part of the webapp. All custom resources declared within
that "resources" property will be exposed relative to a namespaced
directory, not the webapp root:
https://guacamole.apache.org/doc/gug/guacamole-ext.html#ext-manifest
Overriding the tab icon is allowed by the extension subsystem, but you need
to use the properties provided for doing that ("smallIcon" and
"largeIcon"). It looks like those are missing from the docs, but they do
exist and would be specified at the root level of the JSON object making up
the guac-manifest.json:
https://github.com/apache/guacamole-client/commit/1a837b9fee5d56edd32461829f3c7e3ccfb9b1df
- Mike