You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/09/23 04:55:23 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #3533] [IMPROVE][INFRA] Improve issue template related to test
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 46280fc47 [KYUUBI #3533] [IMPROVE][INFRA] Improve issue template related to test
46280fc47 is described below
commit 46280fc4734d12e1840847e1fa5a71e0526112f4
Author: yikf <yi...@gmail.com>
AuthorDate: Fri Sep 23 12:55:13 2022 +0800
[KYUUBI #3533] [IMPROVE][INFRA] Improve issue template related to test
### _Why are the changes needed?_
This pr aims to improve issue template related to test, It
- remove the flaky test template
- merge flaky test template into the current one as a sub-category of the test issue template
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3533 from Yikf/issue-test-template.
Closes #3533
9fcc6d09 [yikf] Improve test issue template
Authored-by: yikf <yi...@gmail.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.github/ISSUE_TEMPLATE/flaky-test-report.yml | 87 ----------------------------
.github/ISSUE_TEMPLATE/improve-test.yml | 12 +++-
2 files changed, 11 insertions(+), 88 deletions(-)
diff --git a/.github/ISSUE_TEMPLATE/flaky-test-report.yml b/.github/ISSUE_TEMPLATE/flaky-test-report.yml
deleted file mode 100644
index 2f24597a0..000000000
--- a/.github/ISSUE_TEMPLATE/flaky-test-report.yml
+++ /dev/null
@@ -1,87 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-name: Flaky Test Report
-title: "[TEST]"
-description: Describe the flaky test you encountered with Apache Kyuubi
-labels: ["kind:bug,kind:test,priority:major"]
-body:
- - type: markdown
- attributes:
- value: |
- Thank you for finding the time to report the issue! We really appreciate the community's efforts to improve Kyuubi.
-
- - type: checkboxes
- attributes:
- label: Code of Conduct
- description: The Code of Conduct helps create a safe space for everyone. We require that everyone agrees to it.
- options:
- - label: >
- I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
- required: true
-
- - type: checkboxes
- attributes:
- label: Search before asking
- options:
- - label: >
- I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar
- issues.
- required: true
-
- - type: textarea
- attributes:
- label: Describe the flaky test
- placeholder: >
- Please provide the suite, test name and log in which the problem occurred
- validations:
- required: true
-
- - type: textarea
- attributes:
- label: Actions URL
- placeholder: >
- Please provide some link about failure like GitHub Actions url
-
- https://github.com/apache/incubator-kyuubi/actions/runs/XXX
-
- https://github.com/apache/incubator-kyuubi/runs/XXX
- validations:
- required: true
-
- - type: textarea
- attributes:
- label: Parent issue
- value: "#1733"
- validations:
- required: false
-
- - type: checkboxes
- attributes:
- label: Are you willing to submit PR?
- description: >
- A pull request is optional, but we are glad to help you in the contribution process
- especially if you already know a good understanding of how to implement the fix.
- Kyuubi is a community-driven project and we love to bring new contributors in.
- options:
- - label: Yes. I can submit a PR independently to fix.
- - label: Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
- - label: No. I cannot submit a PR at this time.
-
- - type: markdown
- attributes:
- value: "Thanks for taking the time to fill out this bug report!"
diff --git a/.github/ISSUE_TEMPLATE/improve-test.yml b/.github/ISSUE_TEMPLATE/improve-test.yml
index 5297ae238..005c16393 100644
--- a/.github/ISSUE_TEMPLATE/improve-test.yml
+++ b/.github/ISSUE_TEMPLATE/improve-test.yml
@@ -43,11 +43,21 @@ body:
issues.
required: true
+ - type: checkboxes
+ attributes:
+ label: What kind of test improve?
+ options:
+ - label: Fix flaky tests.
+ - label: Fix bug in tests.
+ - label: Increase test coverage.
+ - label: Other kinds of test improve.
+
- type: textarea
attributes:
label: Describe the issues of the existing tests or improvements for new tests
placeholder: >
- Please describe the tests problem you see and how it is needed to be improved.
+ Please describe the tests problem you see and how it is needed to be improved, if it is
+ a flaky test, please provide the link of failure like GitHub Actions url.
validations:
required: true