You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 08:25:27 UTC

[GitHub] [spark] yaooqinn commented on pull request #30367: Revert "[SPARK-33139][SQL] protect setActionSession and clearActiveSession"

yaooqinn commented on pull request #30367:
URL: https://github.com/apache/spark/pull/30367#issuecomment-726599449


   Hi, @cloud-fan if we are going to revert this, there will be no guarantee of global uniqueness of the `ShareState`, it will get constructed again if those clear-APIs are called, see https://github.com/yaooqinn/sugar/blob/master/src/main/scala/com/netease/mammut/spark/training/sql/StaticConfigTest.scala#L41-L50


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org