You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "golden-yang (via GitHub)" <gi...@apache.org> on 2023/10/10 06:53:35 UTC
[PR] Fix tiered store README.md error about Configuration [rocketmq]
golden-yang opened a new pull request, #7436:
URL: https://github.com/apache/rocketmq/pull/7436
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
ISSUE #5923 add README.md file to explain how to use tiered storage.
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
There was a simple configuration error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "golden-yang (via GitHub)" <gi...@apache.org>.
golden-yang commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1754692544
> > @ShadowySpirits Hi, I am trying to use tiered store. Thanks for your work.
> > PTAL
>
> I prefer `filepath`. Actually, the difference between `filePath` and `filepath` is discussed in an early issue: [#6483 (comment)](https://github.com/apache/rocketmq/pull/6483#discussion_r1149143324).
I can accept both `filepath` and `filePath `. Now code and documentation are incompatible, and it should be consistent.
Which one should we change?
org.apache.rocketmq.tieredstore.common.TieredMessageStoreConfig#tieredStoreFilePath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1798182052
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7436](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (371b765) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/0f01df460f78c383a35338aa77eb0fda4c8f2dd3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0f01df4) will **increase** coverage by `0.08%`.
> Report is 15 commits behind head on develop.
> The diff coverage is `39.39%`.
```diff
@@ Coverage Diff @@
## develop #7436 +/- ##
=============================================
+ Coverage 42.97% 43.06% +0.08%
- Complexity 9665 9686 +21
=============================================
Files 1161 1161
Lines 83920 83926 +6
Branches 10898 10899 +1
=============================================
+ Hits 36064 36139 +75
+ Misses 43379 43314 -65
+ Partials 4477 4473 -4
```
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...q/tieredstore/common/TieredMessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvbW1vbi9UaWVyZWRNZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | `68.91% <100.00%> (ø)` | |
| [...q/tieredstore/provider/posix/PosixFileSegment.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL3Byb3ZpZGVyL3Bvc2l4L1Bvc2l4RmlsZVNlZ21lbnQuamF2YQ==) | `67.56% <100.00%> (ø)` | |
| [...he/rocketmq/broker/processor/PopReviveService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==) | `36.38% <25.00%> (ø)` | |
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `40.29% <31.25%> (-0.24%)` | :arrow_down: |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1755369049
@golden-yang I suggest to modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1807557784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1807610213
There is a widely use of filePath in the rocketmq project. The rename operation which not only brings compatibility issues but also conflicts with the naming style of the rocketmq project. It is recommended to reverse this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "golden-yang (via GitHub)" <gi...@apache.org>.
golden-yang commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1754534995
@ShadowySpirits Hi, I am trying to use tiered store. Thanks for your work.
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1756705850
@zhouxinyu Please approve the workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui merged PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1754559674
> @ShadowySpirits Hi, I am trying to use tiered store. Thanks for your work.
>
> PTAL
I prefer `filepath`. Actually, the difference between `filePath` and `filepath` is discussed in an early issue: https://github.com/apache/rocketmq/pull/6483#discussion_r1149143324.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix tiered store README.md error about Configuration [rocketmq]
Posted by "golden-yang (via GitHub)" <gi...@apache.org>.
golden-yang commented on PR #7436:
URL: https://github.com/apache/rocketmq/pull/7436#issuecomment-1756644106
> @golden-yang I suggest to modify the code.
I change tieredStoreFilePath to tieredStoreFilepath. @ShadowySpirits
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org