You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/13 11:27:50 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #6340: make subquery in SubqueryRouteTest work well

strongduanmu opened a new pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340


   Ref #4696 .
   
   Changes proposed in this pull request:
   - modify getSubqueryWhereSegments method to make subquery in SubqueryRouteTest work well
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#discussion_r454101225



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       @tristaZero Thank you for your suggestions, I will check and optimize this function. 😊




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#discussion_r454092992



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       Hi, Sorry for the late feedback.
   Do you think it is possible to move this function to `SelectStatementContext` referring to [#6319](https://github.com/apache/shardingsphere/pull/6319/files).
   Basically, `xxxStatement` is designed as a POJO object, and we put more logic coding into `xxxStatementContext` for `rewriting`.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
##########
@@ -108,15 +106,6 @@
      * @return subquery where segment collection.
      */
     public Collection<WhereSegment> getSubqueryWhereSegments() {
-        Collection<WhereSegment> subqueryWhereSegments = new ArrayList<>();

Review comment:
       Besides, I presume #6319 finished part of your work, so my suggestion is you'd better give it check, and if possible, a coding merging and optimizing is welcomed. :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#issuecomment-658522574


   Hi @strongduanmu  Thanks for your continued efforts!
   To make `SelectStatementContext` simple and clean, `xxxUtil` in a new `util` package is expected to consider. 
   What do you think?
   
   Besides, I also think  #6319  also needs a `xxxUtil`  to extract `all tables` from `SelectStatementContext`. Still, I am not sure it is a practical idea or not. So I'd glad to listen to your thought.  @jingshanglu  @strongduanmu 
   
   Thanks,
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#issuecomment-658583614


   @tristaZero I agree with your idea. Extracting this function into util class will make SelectStatementContext look cleaner. I will optimize this pr later. 😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#issuecomment-657536578


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=h1) Report
   > Merging [#6340](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/70ebe10be7f64111fc284d4dec2370b5710657bd&el=desc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6340/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6340      +/-   ##
   ============================================
   - Coverage     52.46%   52.42%   -0.05%     
     Complexity      452      452              
   ============================================
     Files          1220     1223       +3     
     Lines         21639    21765     +126     
     Branches       3846     3879      +33     
   ============================================
   + Hits          11353    11410      +57     
   - Misses         9555     9621      +66     
   - Partials        731      734       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rdingsphere/sql/parser/sql/util/SubqueryUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdXRpbC9TdWJxdWVyeVV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rite/token/generator/impl/TableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9UYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `77.77% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
   | [...r/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `32.70% <0.00%> (-10.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...xecute/executor/importer/AbstractJDBCImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0Fic3RyYWN0SkRCQ0ltcG9ydGVyLmphdmE=) | `82.19% <0.00%> (-2.19%)` | `0.00% <0.00%> (ø%)` | |
   | [...sphere/scaling/core/config/RdbmsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvUmRibXNDb25maWd1cmF0aW9uLmphdmE=) | `75.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...e/sql/parser/sql/predicate/PredicateExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvcHJlZGljYXRlL1ByZWRpY2F0ZUV4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/binder/statement/dml/DeleteStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RtbC9EZWxldGVTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/binder/statement/dml/UpdateStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RtbC9VcGRhdGVTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../sql/segment/generic/table/SimpleTableSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL3RhYmxlL1NpbXBsZVRhYmxlU2VnbWVudC5qYXZh) | `57.14% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=footer). Last update [70ebe10...7929775](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#issuecomment-657536578


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=h1) Report
   > Merging [#6340](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/70ebe10be7f64111fc284d4dec2370b5710657bd&el=desc) will **increase** coverage by `0.17%`.
   > The diff coverage is `35.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/6340/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6340      +/-   ##
   ============================================
   + Coverage     52.46%   52.63%   +0.17%     
     Complexity      452      452              
   ============================================
     Files          1220     1223       +3     
     Lines         21639    21788     +149     
     Branches       3846     3886      +40     
   ============================================
   + Hits          11353    11469     +116     
   - Misses         9555     9575      +20     
   - Partials        731      744      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../sql/parser/sql/statement/dml/SelectStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `33.21% <35.29%> (-9.99%)` | `0.00 <0.00> (ø)` | |
   | [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1doZXJlQ2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `58.44% <50.00%> (+12.28%)` | `0.00 <0.00> (ø)` | |
   | [...registrycenter/instance/OrchestrationInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtcmVnaXN0cnljZW50ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY29yZS9yZWdpc3RyeWNlbnRlci9pbnN0YW5jZS9PcmNoZXN0cmF0aW9uSW5zdGFuY2UuamF2YQ==) | `87.50% <0.00%> (-12.50%)` | `1.00% <0.00%> (ø%)` | |
   | [...rite/token/generator/impl/TableTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9UYWJsZVRva2VuR2VuZXJhdG9yLmphdmE=) | `77.77% <0.00%> (-11.12%)` | `1.00% <0.00%> (ø%)` | |
   | [...aling/core/config/utils/SyncConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvdXRpbHMvU3luY0NvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `87.50% <0.00%> (-4.81%)` | `0.00% <0.00%> (ø%)` | |
   | [...xecute/executor/importer/AbstractJDBCImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0Fic3RyYWN0SkRCQ0ltcG9ydGVyLmphdmE=) | `82.19% <0.00%> (-2.19%)` | `0.00% <0.00%> (ø%)` | |
   | [...asource/OrchestrationShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvT3JjaGVzdHJhdGlvblNoYXJkaW5nU3BoZXJlRGF0YVNvdXJjZS5qYXZh) | `46.93% <0.00%> (-0.54%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [18 more](https://codecov.io/gh/apache/shardingsphere/pull/6340/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=footer). Last update [70ebe10...8aa91ac](https://codecov.io/gh/apache/shardingsphere/pull/6340?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6340: make subquery in SubqueryRouteTest work well

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org