[jira] [Created] (VCL-897) Simplify arguments accepted by grant_root_access subroutines

["Andy Kurth (JIRA)" <ji...@apache.org>]

Andy Kurth created VCL-897:
------------------------------

             Summary: Simplify arguments accepted by grant_root_access subroutines
                 Key: VCL-897
                 URL: https://issues.apache.org/jira/browse/VCL-897
             Project: VCL
          Issue Type: Improvement
          Components: vcld (backend)
            Reporter: Andy Kurth
            Assignee: Andy Kurth
             Fix For: 2.5


The {{grant_root_access}} subroutines in {{Linux.pm}} and {{Windows.pm}} accept a hash reference argument which must contain a _username_ key.  The username is the only piece of information {{grant_root_access}} needs.  The hash reference argument was presumably a result of copying and pasting the arguments accepted by its caller, the {{create_user}} subroutine which requires the other pieces of information contained in the hash reference.

There is no point of passing information to {{grant_root_access}} which it doesn't need.  It would be better programming style to pass it a simple string containing the username.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)