You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/16 14:42:16 UTC
[GitHub] [cloudstack] DK101010 opened a new pull request #4828: Feat/global vm search
DK101010 opened a new pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828
### Description
This PR is more an POC and I need some opinions.
Background:
Many of my admins have the problem that they are get an vm name with a problem but not the related project. In this situation they must check all project to find them. Currently they are using a script to get all vm's with related projects, but they want also a opportunity in the ui.
For this reason I build up a new command class as a first step and after this I want to create a search field in the ui to see a list of vm names and the related project names. I'm continue thought me that the admin can click on the vm in this list to jump into the vm details or he can click on the project to see the project list view with all vms.
========
The api call works and I get all VM's independent of a certian project . But i have headache with some points.
1. Currently I get to much informations of the vm and I have concerns that I break the permission concept of cloudstack.
The only things that I have found is to set the ReponseView to restricted and the details != all.
2. When I call this api call via cloudmonkey, I get the correct and valid json but I get also this error "on parsing and printing list index out of range". Not sure if it a bug of cloudmonkey or a misconfiguration of my ReponseView
3. Not sure which package the right one is to store the new command.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871944964
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872064166
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-919216721
I've just been playing with this.
I'm 60/40 that the on/off button should be a top-level thing rather than down in the filters.
*** But [scope creep alert] to be **_really_** useful, it would need to be available for all resources - volumes, networks, VRs...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1012087783
> > @DK101010 the ui functionality has to be implemented for other resources also. only vm's for all projects can be listed now but networks, disks, templates cant be searched project wide
>
> I already suspected it as you closed your PR. Can't say when I'll can do it.
>
> Would you like to join me?I think you have much more experience with the ui?
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871992830
UI build: :heavy_multiplication_x:
(SL-JID-307)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871990092
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#discussion_r662077003
##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -211,6 +214,9 @@ export default {
} else if (item === 'tags') {
type = 'tag'
}
+ if (item === 'projectwide') {
Review comment:
```
/jenkins/workspace/acs-ui-builder/ui/src/components/view/SearchView.vue
221:2 error Mixed spaces and tabs no-mixed-spaces-and-tabs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932083493
Hi @davidjumani I'm fixed the reset problem but we have also a additional problem. When you click on a vm with a different project, volumes are not displayed.
I check this but perhaps you have an hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-937636923
@nvazquez is there any reason that this can't go into 4.16? it's a tiny change to a filter in the UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 removed a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 removed a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872225494
Unfortunately, I cannot create another zone for the test due to a lack of resources. Code LGTM, but I get this error with the switch types:
Warning: You cannot set a form field before rendering a field associated with the value. You can use `getFieldDecorator(id, options)` instead `v-decorator="[id, options]"` to register it before render.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871945117
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-919318147
@PaulAngus this PR might be super seeded by #5207 and those be obsolet, since with #5207 you will be able to see all resource from all projects 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-802830177
> @DK101010 I think it would be fine as an additional field in the search filters, visible only to root admins
> Can be done by adding it to https://github.com/apache/cloudstack/blob/master/ui/src/components/view/SearchView.vue
> cc @rhtyd
>
> 
Hi @davidjumani, I checked this file but I have no experience with the ui and I'm a little bit overwhelmed :D. Can you give me a hint where I can find the list of search filter elements ? Are There constants, because I can not find the call to the backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800273973
> @DK101010 It should be possible to find the VM across any project by passing projectid=-1 in the listVirtualMachines API request. It will be simpler to just tweak the UI to do the same in your environment
> @rhtyd Would it be a good idea to add a new filter in the advance search in the UI to search across projects ?
Hi @davidjumani, I had tested your suggestion, it doesn't work . (list virtualmachines name=VM projectid=-1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871989597
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-926482164
@DK101010 The project wide switch does not reset when hitting the reset button in the searchview, can you have a look into it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872837766
@DK101010 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800306260
@DK101010 May I know the version you are using? It works in 4.15. Also does the account making the API call have access to all the VMs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-937740726
Hi @PaulAngus, there's currently one open issue (regression) to be fixed in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-811749398
> @DK101010 The list of search filtres can be found here https://github.com/apache/cloudstack/blob/master/ui/src/config/section/compute.js#L70. A new one can be added by appending it to the list
> Next you'll need to add a switch in SearchView similar to https://github.com/apache/cloudstack/blob/master/ui/src/components/view/SearchView.vue#L49 and ensure that when it's checked, it passes -1 as the projectid
Hi @davidjumani, thanks for your hints, it was really helpful. I'm implement it this and it works but I have trouble with some points.
First the label is not right and I don't know why.
As second when I search with accountwide = true and search again with accountwide=false then looks my url like
vm?page=1&pagesize=10&accountwide=false
For me it looks not so good because accountwide = projectid . But I don't know if it important.
Also I get from time to time an error that the checkbox object haven't a value attribute and I don't know where it comes from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1012067323
> @DK101010 the ui functionality has to be implemented for other resources also. only vm's for all projects can be listed now but networks, disks, templates cant be searched project wide
I already suspected it as you closed your PR. Can't say when I'll can do it.
Would you like to join me?I think you have much more experience with the ui?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872068493
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-308)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-926369778
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800903737
@DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
Could you try executing this as admin ?
```
cmk list accounts -> should return admin
cmk list virtualmachines filter=name,project projectid=-1 listall=true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872080598
@DK101010 I think it would look better as a switch https://www.antdv.com/components/switch/
Otherwise LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800903737
@DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
Could you try executing this as admin ?
```
cmk list virtualmachines filter=name,project projectid=-1 listall=true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-814017590
> @DK101010 So to fix the label, you need to add an entry in en.json for `label.accountwide`, however it would be better if it were `projectwide` instead, similar to `"label.projectwide": "Search Across Projects"`
> Could you send a screenshot of the error ?
Hi @davidjumani, here the screenshot
Sure, I'm rename this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-926369517
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932115698
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-719)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1011913281
@DK101010 the ui functionality has to be implemented for other resources also. only vm's for all projects can be listed now but networks, disks, templates cant be searched project wide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1060547090
> Hi @DK101010 @utchoang can you please advise if this PR is ready or needs more work?
@nvazquez
Hi, japp, a couple of things still to do here. Next to this bug that @utchoang mentioned , we need to extend the global search for other resources like network and so on.
I have currently no time for that, but @ravening wants to help to implement the logic for the other resources.
Additional to these I found also a problem. Currently you can only use the global search in the default view. Therefore we need to check the project id or clear the id as soon the global search is in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800903737
@DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
Could you try executing this as admin ?
```
cmk list accounts # should return admin
cmk list virtualmachines filter=name,project projectid=-1 listall=true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-919990854
> @PaulAngus this PR might be super seeded by #5207 and those be obsolet, since with #5207 you will be able to see all resource from all projects 😉
looks like #5207 is another way of doing it.
Arguably #5207 is unnecessary as the function is already available in the API (projectid=-1), It's purely a UI change to expose it in the GUI.
And an on/off switch in the UI is much more flexible too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800182362
@DK101010 It should be possible to find the VM across any project by passing projectid=-1 in the request. It will be simpler to just tweak the UI to do the same in your environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1059947954
Hi @DK101010 @utchoang can you please advise if this PR is ready or needs more work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1060084598
@nvazquez everything seems fine, but there is 1 problem I mentioned above but not solved yet. @DK101010 can you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-806400721
@DK101010 The list of search filtres can be found here https://github.com/apache/cloudstack/blob/master/ui/src/config/section/compute.js#L70. A new one can be added by appending it to the list
Next you'll need to add a switch in SearchView similar to https://github.com/apache/cloudstack/blob/master/ui/src/components/view/SearchView.vue#L49 and ensure that when it's checked, it passes -1 as the projectid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1060547090
> Hi @DK101010 @utchoang can you please advise if this PR is ready or needs more work?
@nvazquez
Hi, japp, a couple of things still to do here. Next to this bug that @utchoang mentioned , we need to extend the global search for other resources like network and so on.
I have currently no time for that, but @ravening wants to help to implement the logic for the other resources.
Additional to these I found also a problem. Currently you can only use the global search in the default view. Therefore we need to check the project id or clear the id as soon the global search is in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-813932807
@DK101010 So to fix the label, you need to add an entry in en.json for `label.accountwide`, however it would be better if it were `projectwide` instead, similar to `"label.projectwide": "Search Across Projects"`
Could you send a screenshot of the error ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800182362
@DK101010 It should be possible to find the VM across any project by passing projectid=-1 in the listVirtualMachines API request. It will be simpler to just tweak the UI to do the same in your environment
@rhtyd Would it be a good idea to add a new filter in the advance search in the UI to search across projects ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800842937
> @DK101010 May I know the version you are using? It works in 4.15. Also does the account making the API call have access to all the VMs ?
I use also the 4.15 and I have different accounts with one project in each account. Hmmm then is your suggestion not that what I want. I will see all VM that are match with my search string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932115129
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-718)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-926372964
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-694)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#discussion_r662004120
##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -211,6 +214,9 @@ export default {
} else if (item === 'tags') {
type = 'tag'
}
+ if (item === 'projectwide') {
Review comment:
@DK101010 Can you fix the indentation error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800903737
@DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
Could you try executing this ?
```
list virtualmachines filter=name,project projectid=-1 listall=true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800842937
> @DK101010 May I know the version you are using? It works in 4.15. Also does the account making the API call have access to all the VMs ?
@davidjumani I use also the 4.15 and I have different accounts with one project in each account. Hmmm then is your suggestion not that what I want. I will see all VM's that are match with my search string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872837313
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932114608
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-717)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932110402
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-937636923
@nvazquez is there any reason that this can't go into 4.16? it's a tiny change to a filter in the UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800922099
> @DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
> Could you try executing this as admin ?
>
> ```
> cmk list accounts # should return admin
> cmk list virtualmachines filter=name,project projectid=-1 listall=true
> ```
with listall=true I get all machines ... nice. Btw. I have also tested this in the prod env(4.13) I works also well, without listall. OK so my commits are unavailing :(. No matter, as next is the question how to add this to the ui. As a Filter option or in a separated search field? In my opinion, it could be confusing to use a search field in the project view to find object outside this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800861040
> @DK101010 If the account doesn't have access to those VMs, then creating a new API to fetch all VMs will cause a security issue as one account should not be able to view the resources of another account unless it is an admin or explicitly granted access. It will be better to have a root admin use the list virtualmachiens to filter out the VMs across projects
@davidjumani I already use a root admin
I use the same account/user in cloudmonkey.
Or do you mean I should adapt the implementation of listVirtualMaschine ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-801011679
@DK101010 I think it would be fine as an additional field in the search filters, visible only to root admins
Can be done by adding it to https://github.com/apache/cloudstack/blob/master/ui/src/components/view/SearchView.vue
cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-871948487
UI build: :heavy_multiplication_x:
(SL-JID-305)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on a change in pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on a change in pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#discussion_r662113384
##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -211,6 +214,9 @@ export default {
} else if (item === 'tags') {
type = 'tag'
}
+ if (item === 'projectwide') {
Review comment:
@davidjumani sorry, github seems to be act strange with tabs and spaces. I've solved and checked with lint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872225494
Unfortunately, I cannot create another zone for the test due to a lack of resources. Code LGTM, but I get this error with the switch types:
Warning: You cannot set a form field before rendering a field associated with the value. You can use `getFieldDecorator(id, options)` instead `v-decorator="[id, options]"` to register it before render.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800922099
> @DK101010 As admin, It should work and display VMs in all projects if projectid=-1 and listall=true
> Could you try executing this as admin ?
>
> ```
> cmk list accounts # should return admin
> cmk list virtualmachines filter=name,project projectid=-1 listall=true
> ```
@davidjumani with listall=true I get all machines ... nice. Btw. I have also tested this in the prod env(4.13) I works also well, without listall. OK so my commits are unavailing :(. No matter, as next is the question how to add this to the ui. As a Filter option or in a separated search field? In my opinion, it could be confusing to use a search field in the project view to find object outside this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800850482
@DK101010 If the account doesn't have access to those VMs, then creating a new API to fetch all VMs will cause a security issue as one account should not be able to view the resources of another account unless it is an admin or explicitly granted access. It will be better to have a root admin use the list virtualmachiens to filter out the VMs across projects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872840508
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4828 (SL-JID-313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-872065002
@DK101010 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-800182362
@DK101010 It should be possible to find the VM across any project by passing projectid=-1 in the listVirtualMachines API request. It will be simpler to just tweak the UI to do the same in your environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-927563822
> @DK101010 The project wide switch does not reset when hitting the reset button in the searchview, can you have a look into it ?
I'm a little surprised that we want to use the PR after all, but I'll look at the problem as soon as I have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-937740726
Hi @PaulAngus, there's currently one open issue (regression) to be fixed in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-932112818
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-940039898
> Hi @davidjumani I'm fixed the reset problem but we have also a additional problem. When you click on a vm with a different project, volumes are not displayed. 
>
> I check this but perhaps you have an hint.
volumes are now displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-823187396
@DK101010 That shouldn't be an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4828: Feat/global vm search
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4828:
URL: https://github.com/apache/cloudstack/pull/4828#issuecomment-1060084598
@nvazquez cc @DK101010 everything seems fine, but there is 1 problem I mentioned above but not solved yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org