You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/02 22:09:01 UTC

[GitHub] [superset] justinpark commented on a diff in pull request #21315: fix(explore): Prevent shared controls from checking feature flags outside React render

justinpark commented on code in PR #21315:
URL: https://github.com/apache/superset/pull/21315#discussion_r1012338561


##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -237,7 +237,7 @@ export interface BaseControlConfig<
   ) => boolean;
   mapStateToProps?: (
     state: ControlPanelState,
-    controlState: ControlState,
+    controlState?: ControlState,

Review Comment:
   @codyml why do you make this parameter optional?
   This breaks all our custom override type checking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org