You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by James Peach <jp...@apache.org> on 2012/02/09 06:02:46 UTC
default number of SSL threads
Hi all,
In getNumSSLThreads(), there is the following comment:
// Set number of ssl threads equal to num of processors if
// SSL is enabled so it will scale properly. If SSL is not
// enabled, leave num of ssl threads one, incase a remap rule
// requires traffic server to act as an ssl client.
However, if SSL is not enabled. getNumSSLThreads() returns 0. In this case, SSLNetProcessor::start() will fail.
So is the code wrong or is the commend wrong?
J
Re: default number of SSL threads
Posted by "Alan M. Carroll" <am...@network-geographics.com>.
I may have broken that in my last patch. I know I had to make changes there. I recommend tweaking the code to follow the comment, and then implementing dynamic SSLNetProcessor.
Wednesday, February 8, 2012, 11:02:46 PM, you wrote:
> Hi all,
> In getNumSSLThreads(), there is the following comment:
> // Set number of ssl threads equal to num of processors if
> // SSL is enabled so it will scale properly. If SSL is not
> // enabled, leave num of ssl threads one, incase a remap rule
> // requires traffic server to act as an ssl client.
> However, if SSL is not enabled. getNumSSLThreads() returns 0. In this case, SSLNetProcessor::start() will fail.
> So is the code wrong or is the commend wrong?
> J
Re: default number of SSL threads
Posted by Leif Hedstrom <zw...@apache.org>.
On 2/8/12 11:18 PM, James Peach wrote:
> On 08/02/2012, at 9:02 PM, James Peach wrote:
>
>> Hi all,
>>
>> In getNumSSLThreads(), there is the following comment:
>>
>> // Set number of ssl threads equal to num of processors if
>> // SSL is enabled so it will scale properly. If SSL is not
>> // enabled, leave num of ssl threads one, incase a remap rule
>> // requires traffic server to act as an ssl client.
>>
>> However, if SSL is not enabled. getNumSSLThreads() returns 0. In this case, SSLNetProcessor::start() will fail.
>>
>> So is the code wrong or is the commend wrong?
>
I think that might be me doing it. I have a vague recollection of turning
off the SSLprocessor if SSL is not enabled. It seemed (at the time at
least) illogical to start the SSLprocessor with SSL disabled. It's probably
Ok to always start it up, it ought to be marginal overhead (memory, CPU etc.).
Not sure how you plan on enabling this, I think your ideas are sound (I
agree that "automation" is better then "manual", in fact, that's one of our
strength, e.g. how we auto scale net-threads). It just might be difficult
since plugins are loaded much later.
Cheers,
-- leif
Re: default number of SSL threads
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> On 08/02/2012, at 9:02 PM, James Peach wrote:
>
> > Hi all,
> >
> > In getNumSSLThreads(), there is the following comment:
> >
> > // Set number of ssl threads equal to num of processors if
> > // SSL is enabled so it will scale properly. If SSL is not
> > // enabled, leave num of ssl threads one, incase a remap rule
> > // requires traffic server to act as an ssl client.
> >
> > However, if SSL is not enabled. getNumSSLThreads() returns 0. In
> > this case, SSLNetProcessor::start() will fail.
> >
> > So is the code wrong or is the commend wrong?
>
> And by way of context ... the reason that I'm interested in this area
> is that I want to auto-enable SSL if a plugin needs it. In the
> future, there might not be any SSL ports configured, but a plugin
> might create one (in principle this could happen at any time). When
> this happens, it's too late to start additional SSL threads. I was
> thinking of dynamically allocating sslNetProcessor when we need to
> configure an SSL port, but I'm definitely interested in other
> suggestions ;)
to quote you yourself from #traffic-server:
00:22:47 < jpeach> auto is better imho
+1
> J
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: default number of SSL threads
Posted by James Peach <jp...@apache.org>.
On 08/02/2012, at 9:02 PM, James Peach wrote:
> Hi all,
>
> In getNumSSLThreads(), there is the following comment:
>
> // Set number of ssl threads equal to num of processors if
> // SSL is enabled so it will scale properly. If SSL is not
> // enabled, leave num of ssl threads one, incase a remap rule
> // requires traffic server to act as an ssl client.
>
> However, if SSL is not enabled. getNumSSLThreads() returns 0. In this case, SSLNetProcessor::start() will fail.
>
> So is the code wrong or is the commend wrong?
And by way of context ... the reason that I'm interested in this area is that I want to auto-enable SSL if a plugin needs it. In the future, there might not be any SSL ports configured, but a plugin might create one (in principle this could happen at any time). When this happens, it's too late to start additional SSL threads. I was thinking of dynamically allocating sslNetProcessor when we need to configure an SSL port, but I'm definitely interested in other suggestions ;)
J