[GitHub] [rocketmq-dashboard] Oliverwqcwrw commented on a diff in pull request #158: [#5538] message type was missing from TopicConfigInfo in rocketmq-das…

["Oliverwqcwrw (via GitHub)" <gi...@apache.org>]

Oliverwqcwrw commented on code in PR #158:
URL: https://github.com/apache/rocketmq-dashboard/pull/158#discussion_r1184447308


##########
src/main/java/org/apache/rocketmq/dashboard/model/request/TopicConfigInfo.java:
##########
@@ -91,6 +94,14 @@ public void setOrder(boolean order) {
         this.order = order;
     }
 
+    public String getMessageType() {
+        return messageType;
+    }
+
+    public void setMessageType(TopicConfig topicConfig) {
+        this.messageType = topicConfig.getAttributes().getOrDefault("message.type", "");

Review Comment:
   It is better to set NORMAL when the message type is empty,
   WDYT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org