[jira] [Work logged] (ARTEMIS-2618) Improve Handling of Shutdown on critical I/O Error

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2618?focusedWorklogId=722060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722060 ]

ASF GitHub Bot logged work on ARTEMIS-2618:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Feb/22 16:58
            Start Date: 07/Feb/22 16:58
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1031694156


   This idea has merit, but there a couple problems:
   
    - The code isn't formatted properly so CheckStyle is failing.
    - The retry is limited to `org.apache.activemq.artemis.core.io.nio.NIOSequentialFile#open(int, boolean)`, but there are several implementations of `org.apache.activemq.artemis.core.io.SequentialFile#open(int, boolean)` which might benefit from such a retry.
    - The configuration should be available from `broker.xml` rather than just a system property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 722060)
    Time Spent: 20m  (was: 10m)

> Improve Handling of Shutdown on critical I/O Error
> --------------------------------------------------
>
>                 Key: ARTEMIS-2618
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2618
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.11.0
>            Reporter: Rico Neubauer
>            Priority: Major
>             Fix For: 2.21.0
>
>         Attachments: Improve-Handling-of-Shutdown-on-critic.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Would like to request an improvement in the handling of critical I/O errors on opening journal files.
> If {{org.apache.activemq.artemis.core.io.nio.NIOSequentialFile}} fails to open a journal file, the whole server shuts down with {{@Message(id = 222010, value = "Critical IO Error, shutting down the server. file=1, message=0"}}.
> We have seen this in the wild, where a backup-software locked the file for a short time while journal was about getting opened, resulting in the shutdown.
> Proposed improvement would be to have a short-running retry for opening the journal files and only fail fatally if error persists.
> Will attach a proposal patch. Can also create a PR if you accept.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)