You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/29 10:40:56 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #5284: [INLONG-5283][Manager] Add OpenAPI authentication option (default off)
woofyzhao opened a new pull request, #5284:
URL: https://github.com/apache/inlong/pull/5284
- Fixes #5283
See the link above for motivation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5284: [INLONG-5283][Manager] Add OpenAPI authentication option (default off)
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5284:
URL: https://github.com/apache/inlong/pull/5284#discussion_r933720010
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/auth/impl/InlongShiroImpl.java:
##########
@@ -59,6 +60,9 @@ public class InlongShiroImpl implements InlongShiro {
@Autowired
private UserService userService;
+ @Value("${openapi.auth.enabled}")
Review Comment:
Suggest adding a default value in the `@Value` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5284: [INLONG-5283][Manager] Add OpenAPI authentication option (default off)
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5284:
URL: https://github.com/apache/inlong/pull/5284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org