You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:02:34 UTC

[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

ChaiBapchya opened a new pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206


   * Integrate MKl-DNN conv3d and pool3d/1d
   
   * fix UT & address comments
   
   * clean code
   
   * rebase against latest master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624377920


   @mxnet-bot run ci [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] zixuanweeei commented on a change in pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on a change in pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#discussion_r419079834



##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -129,15 +129,8 @@ static inline bool SupportMKLDNN(int dtype, const mxnet::TShape &shape) {
     // MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
     return false;
   }
-  return dtype == mshadow::kFloat32 && (ndim == 1 || ndim == 2 || ndim == 4);
-}
-
-static inline bool SupportMKLDNNRnn(const NDArray &input) {

Review comment:
       I think we can drop this function.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624779648


   @mxnet-label-bot add [pr-awaiting-merge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624295138


   @mxnet-bot run ci [unix-cpu, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-623706616


   @wuxun-zhang One last failure
   unix-gpu pipeline
   Tests / Cpp: MKLDNN+GPU
   ```
   pooling-inl.h:313: Check failed: outputs.size() == GetNumOutputs(param) (1 vs. 2) :  
   ```
   I was able to repro locally. Not sure why output size is mismatch for pooling.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-623579507


   `test_quantization_mkldnn.test_quantized_conv` failed with
   ```
   [2020-05-04T03:07:42.847Z] ----------------------------------------------------------------------
   
   [2020-05-04T03:07:42.847Z] Traceback (most recent call last):
   
   [2020-05-04T03:07:42.847Z]   File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest
   
   [2020-05-04T03:07:42.847Z]     self.test(*self.arg)
   
   [2020-05-04T03:07:42.847Z]   File "/usr/local/lib/python3.5/dist-packages/nose/util.py", line 620, in newfunc
   
   [2020-05-04T03:07:42.847Z]     return func(*arg, **kw)
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/tests/python/mkl/../unittest/common.py", line 177, in test_new
   
   [2020-05-04T03:07:42.847Z]     orig_test(*args, **kwargs)
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 283, in test_quantized_conv
   
   [2020-05-04T03:07:42.847Z]     check_quantized_conv((1, 3, 4, 28, 28), (1, 3, 3), 128, (1, 1, 1), (1, 1, 1), (2, 2, 2), False, qdtype)
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 217, in check_quantized_conv
   
   [2020-05-04T03:07:42.847Z]     arg_shapes, _, _ = conv.infer_shape(data=data_shape)
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/python/mxnet/symbol/symbol.py", line 1103, in infer_shape
   
   [2020-05-04T03:07:42.847Z]     res = self._infer_shape_impl(False, *args, **kwargs)
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/python/mxnet/symbol/symbol.py", line 1267, in _infer_shape_impl
   
   [2020-05-04T03:07:42.847Z]     ctypes.byref(complete)))
   
   [2020-05-04T03:07:42.847Z]   File "/work/mxnet/python/mxnet/base.py", line 255, in check_call
   
   [2020-05-04T03:07:42.847Z]     raise MXNetError(py_str(_LIB.MXGetLastError()))
   
   [2020-05-04T03:07:42.847Z] mxnet.base.MXNetError: Error in operator conv: [03:07:30] src/operator/nn/convolution.cc:242: Check failed: param_.dilate.Size() == 1U (8 vs. 1) : Dilate is not supported in 3d convolution
   ```
   
   Cherrypicked #17491 which removed the conv3d dilate restriction.
   That should resolve unix-cpu pipeline errors.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#discussion_r419130984



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -48,10 +48,10 @@ bool SupportMKLDNNAct(const ActivationParam& param) {
 }
 
 bool SupportMKLDNNAct(const ActivationParam& param, const NDArray &input) {
-  // MKL-DNN Activation supports 1d, 2d, 3d, 4d data layout
+  // MKL-DNN Activation supports 1d, 2d, 3d, 4d and 5d data layout
   if ((input.shape().ndim() < 1) ||
-      (input.shape().ndim() > 4) ||
-      (input.dtype() != mshadow::kFloat32))
+      (input.shape().ndim() > 5) ||
+      !(input.dtype() == mshadow::kFloat32 || input.dtype() == mshadow::kBfloat16))

Review comment:
       Addressed.

##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -62,10 +62,10 @@ bool SupportMKLDNNLeakyRelu(const LeakyReLUParam& param) {
 }
 
 bool SupportMKLDNNLeakyRelu(const LeakyReLUParam& param, const NDArray &input) {
-  // MKL-DNN Activation supports 1d, 2d, 3d, 4d data layout
+  // MKL-DNN Activation supports 1d, 2d, 3d, 4d and 5d data layout
   if ((input.shape().ndim() < 1) ||
-      (input.shape().ndim() > 4) ||
-      (input.dtype() != mshadow::kFloat32))
+      (input.shape().ndim() > 5) ||
+      !(input.dtype() == mshadow::kFloat32 || input.dtype() == mshadow::kBfloat16))

Review comment:
       Addressed

##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -129,15 +129,8 @@ static inline bool SupportMKLDNN(int dtype, const mxnet::TShape &shape) {
     // MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
     return false;
   }
-  return dtype == mshadow::kFloat32 && (ndim == 1 || ndim == 2 || ndim == 4);
-}
-
-static inline bool SupportMKLDNNRnn(const NDArray &input) {

Review comment:
       Thanks for confirming!

##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -129,15 +129,8 @@ static inline bool SupportMKLDNN(int dtype, const mxnet::TShape &shape) {
     // MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
     return false;
   }
-  return dtype == mshadow::kFloat32 && (ndim == 1 || ndim == 2 || ndim == 4);
-}
-
-static inline bool SupportMKLDNNRnn(const NDArray &input) {
-  if (input.dtype() == mshadow::kFloat32 && input.shape().ndim() == 3
-      && dmlc::GetEnv("MXNET_USE_MKLDNN_RNN", 1)) {
-    return true;
-  }
-  return false;
+  return (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16) &&

Review comment:
       Addressed

##########
File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
##########
@@ -90,22 +88,47 @@ class MKLDNNPoolingBwd {
 };
 
 inline bool SupportMKLDNNPooling(const PoolingParam &param) {
-  return param.kernel.ndim() == 2 &&
+  return (param.kernel.ndim() == 1 || param.kernel.ndim() == 2 ||
+          param.kernel.ndim() == 3) &&
          (param.pool_type == pool_enum::kMaxPooling ||
           param.pool_type == pool_enum::kAvgPooling) &&
-         (!param.layout.has_value() || param.layout.value() == mshadow::kNCHW);
+         (!param.layout.has_value() ||
+         (param.layout.value() == mshadow::kNCW || param.layout.value() == mshadow::kNCHW ||
+          param.layout.value() == mshadow::kNCDHW));
 }
 
 inline bool SupportMKLDNNPooling(const PoolingParam &param,
-                                 const mxnet::TShape &dshape) {
-  bool ret = SupportMKLDNNPooling(param);
-  if (!ret)
+                                 const NDArray &input) {
+  const auto dshape = input.shape();
+  const auto ndim = dshape.ndim();
+  const auto dtype = input.dtype();
+
+  if (!(SupportStorageMKLDNN(input.storage_type()) && (ndim == 3 || ndim == 4 || ndim == 5) &&
+       (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16)))

Review comment:
       Addressed

##########
File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_base-inl.h
##########
@@ -29,7 +29,9 @@ static inline bool SupportMKLDNNAttr(const std::shared_ptr<NodeAttr>& node_attr)
   if (node_attr) {
     int ndim = node_attr->ishape[0].ndim();
     return (node_attr->dispatch_mode == DispatchMode::kFComputeEx) &&
-           (node_attr->itype[0] == mshadow::kFloat32) && (ndim == 1 || ndim == 2 || ndim == 4);
+           (node_attr->itype[0] == mshadow::kFloat32 ||
+            node_attr->itype[0] == mshadow::kBfloat16) &&

Review comment:
       Addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] wuxun-zhang commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
wuxun-zhang commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624049968


   @ChaiBapchya To fix the unix-gpu issue, you can refer to [this link](https://github.com/apache/incubator-mxnet/pull/18064/commits/ea1c0807b54aa2667b3b08d116a2844987705450), like what I did when backported this PR to v1.x branch before. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] wuxun-zhang commented on a change in pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
wuxun-zhang commented on a change in pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#discussion_r419071370



##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -62,10 +62,10 @@ bool SupportMKLDNNLeakyRelu(const LeakyReLUParam& param) {
 }
 
 bool SupportMKLDNNLeakyRelu(const LeakyReLUParam& param, const NDArray &input) {
-  // MKL-DNN Activation supports 1d, 2d, 3d, 4d data layout
+  // MKL-DNN Activation supports 1d, 2d, 3d, 4d and 5d data layout
   if ((input.shape().ndim() < 1) ||
-      (input.shape().ndim() > 4) ||
-      (input.dtype() != mshadow::kFloat32))
+      (input.shape().ndim() > 5) ||
+      !(input.dtype() == mshadow::kFloat32 || input.dtype() == mshadow::kBfloat16))

Review comment:
       Please remove `input.dtype() == mshadow::kBfloat16` since this should not be supported yet in v1.6.x branch.

##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -48,10 +48,10 @@ bool SupportMKLDNNAct(const ActivationParam& param) {
 }
 
 bool SupportMKLDNNAct(const ActivationParam& param, const NDArray &input) {
-  // MKL-DNN Activation supports 1d, 2d, 3d, 4d data layout
+  // MKL-DNN Activation supports 1d, 2d, 3d, 4d and 5d data layout
   if ((input.shape().ndim() < 1) ||
-      (input.shape().ndim() > 4) ||
-      (input.dtype() != mshadow::kFloat32))
+      (input.shape().ndim() > 5) ||
+      !(input.dtype() == mshadow::kFloat32 || input.dtype() == mshadow::kBfloat16))

Review comment:
       Please remove `input.dtype() == mshadow::kBfloat16` since this should not be supported yet in v1.6.x branch.

##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -129,15 +129,8 @@ static inline bool SupportMKLDNN(int dtype, const mxnet::TShape &shape) {
     // MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
     return false;
   }
-  return dtype == mshadow::kFloat32 && (ndim == 1 || ndim == 2 || ndim == 4);
-}
-
-static inline bool SupportMKLDNNRnn(const NDArray &input) {
-  if (input.dtype() == mshadow::kFloat32 && input.shape().ndim() == 3
-      && dmlc::GetEnv("MXNET_USE_MKLDNN_RNN", 1)) {
-    return true;
-  }
-  return false;
+  return (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16) &&

Review comment:
       Same as before. Please remove `dtype == mshadow::kBfloat16` as well.

##########
File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_base-inl.h
##########
@@ -29,7 +29,9 @@ static inline bool SupportMKLDNNAttr(const std::shared_ptr<NodeAttr>& node_attr)
   if (node_attr) {
     int ndim = node_attr->ishape[0].ndim();
     return (node_attr->dispatch_mode == DispatchMode::kFComputeEx) &&
-           (node_attr->itype[0] == mshadow::kFloat32) && (ndim == 1 || ndim == 2 || ndim == 4);
+           (node_attr->itype[0] == mshadow::kFloat32 ||
+            node_attr->itype[0] == mshadow::kBfloat16) &&

Review comment:
       same as before. Please remove `dtype == mshadow::kBfloat16`.

##########
File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h
##########
@@ -90,22 +88,47 @@ class MKLDNNPoolingBwd {
 };
 
 inline bool SupportMKLDNNPooling(const PoolingParam &param) {
-  return param.kernel.ndim() == 2 &&
+  return (param.kernel.ndim() == 1 || param.kernel.ndim() == 2 ||
+          param.kernel.ndim() == 3) &&
          (param.pool_type == pool_enum::kMaxPooling ||
           param.pool_type == pool_enum::kAvgPooling) &&
-         (!param.layout.has_value() || param.layout.value() == mshadow::kNCHW);
+         (!param.layout.has_value() ||
+         (param.layout.value() == mshadow::kNCW || param.layout.value() == mshadow::kNCHW ||
+          param.layout.value() == mshadow::kNCDHW));
 }
 
 inline bool SupportMKLDNNPooling(const PoolingParam &param,
-                                 const mxnet::TShape &dshape) {
-  bool ret = SupportMKLDNNPooling(param);
-  if (!ret)
+                                 const NDArray &input) {
+  const auto dshape = input.shape();
+  const auto ndim = dshape.ndim();
+  const auto dtype = input.dtype();
+
+  if (!(SupportStorageMKLDNN(input.storage_type()) && (ndim == 3 || ndim == 4 || ndim == 5) &&
+       (dtype == mshadow::kFloat32 || dtype == mshadow::kBfloat16)))

Review comment:
       same as before. Please remove `dtype == mshadow::kBfloat16`.

##########
File path: src/operator/nn/mkldnn/mkldnn_base-inl.h
##########
@@ -129,15 +129,8 @@ static inline bool SupportMKLDNN(int dtype, const mxnet::TShape &shape) {
     // MKLDNN currently does not support 0-dim Tensor and 0-size Tensor
     return false;
   }
-  return dtype == mshadow::kFloat32 && (ndim == 1 || ndim == 2 || ndim == 4);
-}
-
-static inline bool SupportMKLDNNRnn(const NDArray &input) {

Review comment:
       This function should not be removed in v1.6.x branch. Please help confirm @zixuanweeei  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-621980687


   Hey @ChaiBapchya , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [sanity, centos-gpu, miscellaneous, windows-cpu, edge, website, clang, windows-gpu, unix-gpu, unix-cpu, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-622209488


   Jenkins CI successfully triggered : [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] wuxun-zhang commented on a change in pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
wuxun-zhang commented on a change in pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#discussion_r419072396



##########
File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_base-inl.h
##########
@@ -29,7 +29,9 @@ static inline bool SupportMKLDNNAttr(const std::shared_ptr<NodeAttr>& node_attr)
   if (node_attr) {
     int ndim = node_attr->ishape[0].ndim();
     return (node_attr->dispatch_mode == DispatchMode::kFComputeEx) &&
-           (node_attr->itype[0] == mshadow::kFloat32) && (ndim == 1 || ndim == 2 || ndim == 4);
+           (node_attr->itype[0] == mshadow::kFloat32 ||
+            node_attr->itype[0] == mshadow::kBfloat16) &&

Review comment:
       same as before. Please remove `node_attr->itype[0] == mshadow::kBfloat16`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624377949


   Jenkins CI successfully triggered : [unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-622209471


   @mxnet-bot run ci [sanity]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-624295186


   Jenkins CI successfully triggered : [unix-cpu, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] TaoLv commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-622916421


   @wuxun-zhang please help to review ~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18206: [v1.6.x] Backport [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884) and Fix Sanity pipeline in 1.6.x

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18206:
URL: https://github.com/apache/incubator-mxnet/pull/18206#issuecomment-623144761


   @wuxun-zhang Thanks for pointing it out. Addressed your comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org