You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/17 08:20:05 UTC
[GitHub] [netbeans] eirikbakke opened a new pull request #2025:
[NETBEANS-2543] File names clipped in Files and Projects tabs
eirikbakke opened a new pull request #2025: [NETBEANS-2543] File names clipped in Files and Projects tabs
URL: https://github.com/apache/netbeans/pull/2025
This patch fixes a bug where some file names in the "Projects" and "Files" tabs would appear truncated on fractional HiDPI scalings (e.g. 150%) on Windows. It probably also improves text measurement on an integral 200% scaling as well, possibly on MacOS as well.
The problem was in org.openide.awt.HtmlRenderer and the associated HtmlRendererImpl class, which creates a fake Graphics2D object for the purposes of calculating text dimensions in getPreferredWidth. This Graphics2D object was not properly prepared with a HiDPI transform for its FontRenderContext, leading to inaccurate text measurement. Moreover, the GraphicsConfiguration was not retrieved for the correct monitor (in multi-monitor setups). These problems have been fixed.
Since the scratch Graphics2D object is now specific to each monitor (each can have a different HiDPI scaling), it is now cached at the HtmlRenderer level rather than at the previous global (static) level.
An alternative approach would have been to pass a FontRenderContext instead of a full Graphics2D during off-screen text measurements. This would complicate the HtmlRenderer._renderHTML method too much, however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #2025: [NETBEANS-2543] File
names clipped in Files and Projects tabs
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2025: [NETBEANS-2543] File names clipped in Files and Projects tabs
URL: https://github.com/apache/netbeans/pull/2025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #2025: [NETBEANS-2543]
File names clipped in Files and Projects tabs
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #2025: [NETBEANS-2543] File names clipped in Files and Projects tabs
URL: https://github.com/apache/netbeans/pull/2025#issuecomment-611177834
I've been using this patch in my working IDE without problems for 3 weeks now. I've also tested it on MacOS. Should be safe to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists