You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/10 18:29:57 UTC

[GitHub] szha commented on a change in pull request #13559: fix for opencv4

szha commented on a change in pull request #13559: fix for opencv4
URL: https://github.com/apache/incubator-mxnet/pull/13559#discussion_r246871668
 
 

 ##########
 File path: src/io/image_aug_default.cc
 ##########
 @@ -479,14 +479,14 @@ class DefaultImageAugmenter : public ImageAugmenter {
         }
         if (i == 1) {
           // contrast
-          cvtColor(res, temp_, CV_RGB2GRAY);
+          cvtColor(res, temp_, cv::COLOR_RGB2GRAY);
 
 Review comment:
   Can we use macros to define these constants based on the opencv version? This should hopefully make it easier to be compatible with multiple versions of opencv.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services