You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/03/27 11:46:37 UTC

Review Request 57954: Single process executor possibly can cause deadlock

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.


Bugs: AMBARI-20582
    https://issues.apache.org/jira/browse/AMBARI-20582


Repository: ambari


Description
-------

multimple readers of queue can cause deadlock while using empty()+get(True)


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 


Diff: https://reviews.apache.org/r/57954/diff/1/


Testing
-------

mvn clean test, manual test


Thanks,

Eugene Chekanskiy

Re: Review Request 57954: Single process executor possibly can cause deadlock

Posted by Sebastian Toader <st...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170161
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On March 27, 2017, 1:46 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57954/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20582
>     https://issues.apache.org/jira/browse/AMBARI-20582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> multimple readers of queue can cause deadlock while using empty()+get(True)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 
> 
> 
> Diff: https://reviews.apache.org/r/57954/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57954: Single process executor possibly can cause deadlock

Posted by Robert Levas <rl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170173
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On March 27, 2017, 7:46 a.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57954/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 7:46 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20582
>     https://issues.apache.org/jira/browse/AMBARI-20582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> multimple readers of queue can cause deadlock while using empty()+get(True)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 
> 
> 
> Diff: https://reviews.apache.org/r/57954/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57954: Single process executor possibly can cause deadlock

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170159
-----------------------------------------------------------


Ship it!




Ship It!

- Myroslav Papirkovskyy


On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 27, 2017, 2:46 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57954/
> -----------------------------------------------------------
> 
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 27, 2017, 2:46 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20582
>     https://issues.apache.org/jira/browse/AMBARI-20582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> multimple readers of queue can cause deadlock while using empty()+get(True)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 
> 
> 
> Diff: https://reviews.apache.org/r/57954/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57954: Single process executor possibly can cause deadlock

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170204
-----------------------------------------------------------


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py
Lines 58 (patched)
<https://reviews.apache.org/r/57954/#comment242987>

    qlen may need str() around it


- Alejandro Fernandez


On March 27, 2017, 11:46 a.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57954/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20582
>     https://issues.apache.org/jira/browse/AMBARI-20582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> multimple readers of queue can cause deadlock while using empty()+get(True)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 
> 
> 
> Diff: https://reviews.apache.org/r/57954/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57954: Single process executor possibly can cause deadlock

Posted by Andrew Onischuk <ao...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57954/#review170160
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Onischuk


On March 27, 2017, 11:46 a.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57954/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 11:46 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20582
>     https://issues.apache.org/jira/browse/AMBARI-20582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> multimple readers of queue can cause deadlock while using empty()+get(True)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py eaa24c2 
> 
> 
> Diff: https://reviews.apache.org/r/57954/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>