You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Dennis van der Laan (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 16:29:27 UTC
[jira] [Created] (RAVE-526) Support height attribute of open social
gadget definition
Support height attribute of open social gadget definition
---------------------------------------------------------
Key: RAVE-526
URL: https://issues.apache.org/jira/browse/RAVE-526
Project: Rave
Issue Type: Bug
Components: rave-portal
Affects Versions: 0.9-INCUBATING
Environment: All platforms
Reporter: Dennis van der Laan
Priority: Minor
An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236712#comment-13236712 ]
jiraposter@reviews.apache.org commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/#review6284
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
<https://reviews.apache.org/r/4468/#comment13627>
Why not move this logic into getSizeFromElement and rename the function calculateSize ?
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js
<https://reviews.apache.org/r/4468/#comment13628>
if you don't mind, set width to size.width and just replace elem.clientWidth - OFFSET with "100%" in the function.
I know this one isn't your doing but, nothing wrong with fixing it while you are there :)
- mfranklin
On 2012-03-23 15:55:22, Dennis Laan, van der wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4468/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 15:55:22)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
bq. Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
bq.
bq.
bq. This addresses bug RAVE-526.
bq. https://issues.apache.org/jira/browse/RAVE-526
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
bq.
bq. Diff: https://reviews.apache.org/r/4468/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested on gadgets:
bq. - without height attribute and without dynamic height,
bq. - without height and with dynamic height,
bq. - with height and without dynamic height,
bq. - with height and with dynamic height
bq.
bq.
bq. Thanks,
bq.
bq. Dennis
bq.
bq.
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236700#comment-13236700 ]
jiraposter@reviews.apache.org commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/
-----------------------------------------------------------
Review request for rave.
Summary
-------
An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
This addresses bug RAVE-526.
https://issues.apache.org/jira/browse/RAVE-526
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
Diff: https://reviews.apache.org/r/4468/diff
Testing
-------
Tested on gadgets:
- without height attribute and without dynamic height,
- without height and with dynamic height,
- with height and without dynamic height,
- with height and with dynamic height
Thanks,
Dennis
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-526) Support height attribute of open social
gadget definition
Posted by "Dennis van der Laan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis van der Laan updated RAVE-526:
-------------------------------------
Affects Version/s: (was: 0.9-INCUBATING)
0.10-INCUBATING
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "Dennis van der Laan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236677#comment-13236677 ]
Dennis van der Laan commented on RAVE-526:
------------------------------------------
I have a patch which fixes this issue and will provide it asap.
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.9-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236745#comment-13236745 ]
jiraposter@reviews.apache.org commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/
-----------------------------------------------------------
(Updated 2012-03-23 16:27:52.624720)
Review request for rave.
Changes
-------
Made changes based on comments from matt franklin:
- moved all sizing code to getSizeFromElement and renamed it calculateSize
- removed commented code about width and set size to 100% in new calculateSize
Summary
-------
An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
This addresses bug RAVE-526.
https://issues.apache.org/jira/browse/RAVE-526
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
Diff: https://reviews.apache.org/r/4468/diff
Testing
-------
Tested on gadgets:
- without height attribute and without dynamic height,
- without height and with dynamic height,
- with height and without dynamic height,
- with height and with dynamic height
Thanks,
Dennis
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236766#comment-13236766 ]
jiraposter@reviews.apache.org commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/#review6288
-----------------------------------------------------------
Ship it!
Looks good. I will apply it later today unless anyone else reviews with changes.
- mfranklin
On 2012-03-23 16:27:52, Dennis Laan, van der wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4468/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 16:27:52)
bq.
bq.
bq. Review request for rave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
bq. Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
bq.
bq.
bq. This addresses bug RAVE-526.
bq. https://issues.apache.org/jira/browse/RAVE-526
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
bq.
bq. Diff: https://reviews.apache.org/r/4468/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested on gadgets:
bq. - without height attribute and without dynamic height,
bq. - without height and with dynamic height,
bq. - with height and without dynamic height,
bq. - with height and with dynamic height
bq.
bq.
bq. Thanks,
bq.
bq. Dennis
bq.
bq.
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-526) Support height attribute of open
social gadget definition
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236705#comment-13236705 ]
jiraposter@reviews.apache.org commented on RAVE-526:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4468/
-----------------------------------------------------------
(Updated 2012-03-23 15:55:22.362174)
Review request for rave.
Changes
-------
Added issue number to summary
Summary (updated)
-------
An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
This addresses bug RAVE-526.
https://issues.apache.org/jira/browse/RAVE-526
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1295528
Diff: https://reviews.apache.org/r/4468/diff
Testing
-------
Tested on gadgets:
- without height attribute and without dynamic height,
- without height and with dynamic height,
- with height and without dynamic height,
- with height and with dynamic height
Thanks,
Dennis
> Support height attribute of open social gadget definition
> ---------------------------------------------------------
>
> Key: RAVE-526
> URL: https://issues.apache.org/jira/browse/RAVE-526
> Project: Rave
> Issue Type: Bug
> Components: rave-portal
> Affects Versions: 0.10-INCUBATING
> Environment: All platforms
> Reporter: Dennis van der Laan
> Priority: Minor
> Labels: features, javascript
>
> An optional attribute for the ModulePrefs element in a gadget definition is 'height', which states the static or default height of a gadget. Rave currently has a default height of 250px, which is added to the iframe element in which a gadget is created. It does not check if a height attribute is set on the gadget to render.
> Because iGoogle supports the height attribute and a lot of available gadgets set their height statically, it would be a nice feature for Rave to support the height attribute as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira