Re: cvs commit: apache-2.0/src/lib/apr/locks/unix crossproc.c

[rb...@covalent.net]

This change needs to be backed out.  The pthreads spec does not use errno
to report errors.  Every pthreads function I know of off the top of my
head returns 0 on success and an error code on error.

Errno shouldn't be used at all with pthreads.

Ryan

On 21 Jul 2000 trawick@locus.apache.org wrote:

> trawick     00/07/21 09:48:28
> 
>   Modified:    src/lib/apr/locks/unix crossproc.c
>   Log:
>   Fix some error-trapping logic in the APR_USE_PROC_PTHREAD_SERIALIZE
>   implementation.
>   
>   Revision  Changes    Path
>   1.34      +13 -13    apache-2.0/src/lib/apr/locks/unix/crossproc.c
>   


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------

Re: cvs commit: apache-2.0/src/lib/apr/locks/unix crossproc.c

[Jeff Trawick <tr...@bellsouth.net>]

rbb@covalent.net writes:

> This change needs to be backed out.  The pthreads spec does not use errno
> to report errors.  Every pthreads function I know of off the top of my
> head returns 0 on success and an error code on error.
> 
> Errno shouldn't be used at all with pthreads.
> 

Oops!  Unfortunately, OS/390, which is where I found the problem
empirically, must follow an earlier spec as it returns -1/errno from
pthread functions.  I'll rework the code to do the appropriate thing
based on how errors are reported on the platform.

Bummer...
-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...