You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/28 15:53:26 UTC

[GitHub] [incubator-nuttx] NicholasChin opened a new pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

NicholasChin opened a new pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145


   ## Summary
   I have created a usbhost driver for the FT232R. The CDC/ACM driver was used as a basis.
   
   ## Testing
   I have test built using the current head 48c88f2 and the imxrt1020-evk:nsh config with all the Kconfig options I added to support the driver. It builds without warnings from my additions. I have ran NXstyle and addressed the issues from that, but I believe it's giving me a lot of false positives.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635468920


   I just fixed the nxstyle problems, rebased, and pushed to your branch.
   
   Everything should be good now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] NicholasChin commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
NicholasChin commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635444714


   Oh must have missed that one. The box to allows maintainers access is checked, so you should be able to edit usbhost.c, Greg. However like I was trying to articulate in my initial comment, it seems like most of the nxstyle errors in usbhost.c are false positives.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] NicholasChin commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
NicholasChin commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635459461


   I'm at a loss for why checkpatch is reporting:
   `drivers/usbhost/usbhost_ft232r.c:831:26: error: Multiple data definitions`
   
   The line it is complaining about is a simple array instantiation and the variable name is unique:
   `int divfrac[9] = {0,
                           500,
                           250,
                           125,
                           375,
                           625,
                           750,
                           875,
                           1000};`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635470410


   In usbhost.h, the main problem was that there was a missing */ which confused nxstyle.
   
   in the ft232 file, nxstyle was getting upset about the braces not being on the same line, I don't know why it gave such a bogus error string.  That tools is critical, but still needs a lot of work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635455020


   I am looking at usbhost.h now.  I will try to push something to your branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635440002


   I can also help you with the usbhost.h files if you remembered to keep the box check to allow maintainers access to your branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635438863


   There are a few style problems that need to be fixed before we can do the merge.  There is one in your new files?
   
   drivers/usbhost/usbhost_ft232r.c:831:26: error: Multiple data definitions
   
   But lots in the existing file:  include/nuttx/usb/usbhost.h.  Most of those are probably not yours, but we ask people to clean up style-related problems in an all modified files.  Think of it as your way to contribute to the quality of the OS ;)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org