You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/17 07:23:04 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
HeimingZ opened a new pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073
Change default value of sync mlog period parameter from 0 to 100.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun commented on pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
chengjianyun commented on pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073#issuecomment-1042678943
> 0 will sharply decrease the performance of creating timeseries. So change it to 100, the same as force_wal_period_in_ms
I see. How sharply is that? Do you have any test result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun commented on pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
chengjianyun commented on pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073#issuecomment-1042649925
Is there any background of the update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073#issuecomment-1042700428
> > 0 will sharply decrease the performance of creating timeseries. So change it to 100, the same as force_wal_period_in_ms
>
> I see. How sharply is that? Do you have any test result?
I tested it with benchmark and found that the registration timing was so slow that I killed the test. This can estimate the speed drop. When it is 0, it takes about 10ms to access the disk each time a sequence is created, and it is estimated that about 100 sequences are created per second. When it is 100, a time series is 300 bytes, 1MB cache can carry about 3000 times, and the cache is flushed 10 times per second, and about 30,000 time series can be created. There are two orders of magnitude difference in speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073#issuecomment-1042702509
[](https://coveralls.io/builds/46631503)
Coverage increased (+0.02%) to 67.771% when pulling **91438fb99d2aecc81066dbca93f314ed28453eb5 on HeimingZ:IOTDB-2562** into **f4ecf3a5b711a9985076946f3e10202404546c5a on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on pull request #5073: [IOTDB-2562] Change default value of sync mlog period parameter
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #5073:
URL: https://github.com/apache/iotdb/pull/5073#issuecomment-1042668279
0 will sharply decrease the performance of creating timeseries. So change it to 100, the same as force_wal_period_in_ms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org