You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Vladimir Kotikov (Akvelon)" <v-...@microsoft.com> on 2015/09/01 15:06:46 UTC
RE: Cordova-lib refactoring implementation
FYI, I'm going to merge this in next 12 hours.
Best regards, Vladimir.
-----Original Message-----
From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
Sent: Wednesday, August 26, 2015 6:27 PM
To: dev@cordova.apache.org
Subject: RE: Cordova-lib refactoring implementation
Jesse wanted to look into it a bit more, so probably this will be merged at the end of this week.
Best regards, Vladimir.
-----Original Message-----
From: Anis KADRI [mailto:anis.kadri@gmail.com]
Sent: Wednesday, August 26, 2015 11:27 AM
To: dev@cordova.apache.org
Subject: Re: Cordova-lib refactoring implementation
Do it!
On Tue, Aug 25, 2015 at 5:09 PM Vladimir Kotikov (Akvelon) < v-vlkoti@microsoft.com> wrote:
> Hey, guys. The PRs has been reviewed by Mark and Sergey.
> If nobody has any objections, I would like to merge this in tomorrow.
> ------------------------
> Best regards, Vladimir.
>
> -----Original Message-----
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
> Sent: Friday, August 21, 2015 6:57 PM
> To: dev@cordova.apache.org
> Subject: RE: Cordova-lib refactoring implementation
>
> Oops, previous email sent by mistake ☹
>
> Hi, guys.
>
> I’ve submitted a PR, that refactors a cordova-lib API and implements a
> PlatformApi polyfill (as discussed in
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fcordova%2fcordova-discuss%2fpull%2f12&data=01%7c01%7cv-vlkoti%
> 40064d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf
> 86f141af91ab2d7cd011db47%7c1&sdata=Fd24ZInammyzOtVRlb2qBvHNxaohF9ms50j
> 3dhIAkGs%3d
> )
> Please find it here:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-lib%2fpull%2f282.&data=01%7c01%7cv-vlkoti%400
> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86f
> 141af91ab2d7cd011db47%7c1&sdata=PzMbKu4Hb9Oe4NfkwBsIOZcwfcl31Oq%2fU%2f
> VdqBwlqgk%3d To test this you'll also need to check out corresponding
> PR to
> cordova-cli:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-cli%2fpull%2f220.&data=01%7c01%7cv-vlkoti%400
> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86f
> 141af91ab2d7cd011db47%7c1&sdata=IUZpWxvf1bu1x7Jb6UYLrdW10G6bMmvJ8Kl09%
> 2fq0Mtk%3d
>
> This is a first step of refactoring, which includes cordova-lib
> refactoring only.
> The next steps once this PR will be reviewed and merged:
> * Move shared code for platforms/cordova-lib into cordova-common
> module
> * Prepare and publish cordova-common (this also includes coho update)
> * Switch cordova-lib to use cordova-common
>
> Brief overview of this PR:
> It implements PlatformApiPoly class according to PlatformApi spec,
> which allows to:
> * create/update platform
> * execute platform's actions (build/run/add/update)
> * do a prepare (needed for CLI workflow only)
> * install/uninstall plugins
>
> Other noticeable changes:
> * removes `getPlatformProject` and PlatformProject method/class in
> favor of PlatformApiPoly/getPlatformApi
> * make assets and js-modules installing/uninstalling through ActionStack
> * refactor configChanges to not require plugins_dir in constructor
> * moves mergeXml helper to xml-helpers
>
> I would appreciate any feedback on this PR.
> ------------------------
> Best regards, Vladimir.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
RE: Cordova-lib refactoring implementation
Posted by "Vladimir Kotikov (Akvelon)" <v-...@microsoft.com>.
Hey guys.
Here is the next step of PlatformApi refactoring - moving shared code to separate module.
Please find PR for this: https://github.com/apache/cordova-lib/pull/309
There is also a PR to 'coho', adding cordova-common to known repos and 'npm-link' command: https://github.com/apache/cordova-coho/pull/94
Would be great to see any comments/notes.
-
Best regards, Vladimir.
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]
Sent: Tuesday, September 1, 2015 6:25 PM
To: dev@cordova.apache.org
Subject: Re: Cordova-lib refactoring implementation
Yes. I am done.
Looks good!
> On Sep 1, 2015, at 6:06 AM, Vladimir Kotikov (Akvelon) <v-...@microsoft.com> wrote:
>
> FYI, I'm going to merge this in next 12 hours.
>
> Best regards, Vladimir.
>
> -----Original Message-----
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
> Sent: Wednesday, August 26, 2015 6:27 PM
> To: dev@cordova.apache.org
> Subject: RE: Cordova-lib refactoring implementation
>
> Jesse wanted to look into it a bit more, so probably this will be merged at the end of this week.
>
> Best regards, Vladimir.
>
> -----Original Message-----
> From: Anis KADRI [mailto:anis.kadri@gmail.com]
> Sent: Wednesday, August 26, 2015 11:27 AM
> To: dev@cordova.apache.org
> Subject: Re: Cordova-lib refactoring implementation
>
> Do it!
>
>> On Tue, Aug 25, 2015 at 5:09 PM Vladimir Kotikov (Akvelon) < v-vlkoti@microsoft.com> wrote:
>>
>> Hey, guys. The PRs has been reviewed by Mark and Sergey.
>> If nobody has any objections, I would like to merge this in tomorrow.
>> ------------------------
>> Best regards, Vladimir.
>>
>> -----Original Message-----
>> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
>> Sent: Friday, August 21, 2015 6:57 PM
>> To: dev@cordova.apache.org
>> Subject: RE: Cordova-lib refactoring implementation
>>
>> Oops, previous email sent by mistake ☹
>>
>> Hi, guys.
>>
>> I’ve submitted a PR, that refactors a cordova-lib API and
>> implements a PlatformApi polyfill (as discussed in
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
>> u
>> b.com%2fcordova%2fcordova-discuss%2fpull%2f12&data=01%7c01%7cv-vlkoti
>> %
>> 40064d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988b
>> f
>> 86f141af91ab2d7cd011db47%7c1&sdata=Fd24ZInammyzOtVRlb2qBvHNxaohF9ms50
>> j
>> 3dhIAkGs%3d
>> )
>> Please find it here:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
>> u
>> b.com%2fapache%2fcordova-lib%2fpull%2f282.&data=01%7c01%7cv-vlkoti%40
>> 0
>> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86
>> f
>> 141af91ab2d7cd011db47%7c1&sdata=PzMbKu4Hb9Oe4NfkwBsIOZcwfcl31Oq%2fU%2
>> f VdqBwlqgk%3d To test this you'll also need to check out
>> corresponding PR to
>> cordova-cli:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
>> u
>> b.com%2fapache%2fcordova-cli%2fpull%2f220.&data=01%7c01%7cv-vlkoti%40
>> 0
>> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86
>> f
>> 141af91ab2d7cd011db47%7c1&sdata=IUZpWxvf1bu1x7Jb6UYLrdW10G6bMmvJ8Kl09
>> %
>> 2fq0Mtk%3d
>>
>> This is a first step of refactoring, which includes cordova-lib
>> refactoring only.
>> The next steps once this PR will be reviewed and merged:
>> * Move shared code for platforms/cordova-lib into cordova-common
>> module
>> * Prepare and publish cordova-common (this also includes coho update)
>> * Switch cordova-lib to use cordova-common
>>
>> Brief overview of this PR:
>> It implements PlatformApiPoly class according to PlatformApi spec,
>> which allows to:
>> * create/update platform
>> * execute platform's actions (build/run/add/update)
>> * do a prepare (needed for CLI workflow only)
>> * install/uninstall plugins
>>
>> Other noticeable changes:
>> * removes `getPlatformProject` and PlatformProject method/class in
>> favor of PlatformApiPoly/getPlatformApi
>> * make assets and js-modules installing/uninstalling through
>> ActionStack
>> * refactor configChanges to not require plugins_dir in constructor
>> * moves mergeXml helper to xml-helpers
>>
>> I would appreciate any feedback on this PR.
>> ------------------------
>> Best regards, Vladimir.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
> ТÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒ
> ÐÐ¥Fò
> Vç7V'67&–&RÂRÖ֖âFWb×Vç7V'67&–&T6÷&F÷fæ6†Ræ÷&pФf÷"FF—F–öæ
> Â6öÖÖæG2ÂRÖ֖âFWbÖ†VÇ6÷&F÷fæ6†Ræ÷&pÐ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Cordova-lib refactoring implementation
Posted by Jesse <pu...@gmail.com>.
Yes. I am done.
Looks good!
> On Sep 1, 2015, at 6:06 AM, Vladimir Kotikov (Akvelon) <v-...@microsoft.com> wrote:
>
> FYI, I'm going to merge this in next 12 hours.
>
> Best regards, Vladimir.
>
> -----Original Message-----
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
> Sent: Wednesday, August 26, 2015 6:27 PM
> To: dev@cordova.apache.org
> Subject: RE: Cordova-lib refactoring implementation
>
> Jesse wanted to look into it a bit more, so probably this will be merged at the end of this week.
>
> Best regards, Vladimir.
>
> -----Original Message-----
> From: Anis KADRI [mailto:anis.kadri@gmail.com]
> Sent: Wednesday, August 26, 2015 11:27 AM
> To: dev@cordova.apache.org
> Subject: Re: Cordova-lib refactoring implementation
>
> Do it!
>
>> On Tue, Aug 25, 2015 at 5:09 PM Vladimir Kotikov (Akvelon) < v-vlkoti@microsoft.com> wrote:
>>
>> Hey, guys. The PRs has been reviewed by Mark and Sergey.
>> If nobody has any objections, I would like to merge this in tomorrow.
>> ------------------------
>> Best regards, Vladimir.
>>
>> -----Original Message-----
>> From: Vladimir Kotikov (Akvelon) [mailto:v-vlkoti@microsoft.com]
>> Sent: Friday, August 21, 2015 6:57 PM
>> To: dev@cordova.apache.org
>> Subject: RE: Cordova-lib refactoring implementation
>>
>> Oops, previous email sent by mistake ☹
>>
>> Hi, guys.
>>
>> I’ve submitted a PR, that refactors a cordova-lib API and implements a
>> PlatformApi polyfill (as discussed in
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
>> b.com%2fcordova%2fcordova-discuss%2fpull%2f12&data=01%7c01%7cv-vlkoti%
>> 40064d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf
>> 86f141af91ab2d7cd011db47%7c1&sdata=Fd24ZInammyzOtVRlb2qBvHNxaohF9ms50j
>> 3dhIAkGs%3d
>> )
>> Please find it here:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
>> b.com%2fapache%2fcordova-lib%2fpull%2f282.&data=01%7c01%7cv-vlkoti%400
>> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86f
>> 141af91ab2d7cd011db47%7c1&sdata=PzMbKu4Hb9Oe4NfkwBsIOZcwfcl31Oq%2fU%2f
>> VdqBwlqgk%3d To test this you'll also need to check out corresponding
>> PR to
>> cordova-cli:
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
>> b.com%2fapache%2fcordova-cli%2fpull%2f220.&data=01%7c01%7cv-vlkoti%400
>> 64d.mgd.microsoft.com%7c9ff61bc6ceae43538c1008d2aa420cba%7c72f988bf86f
>> 141af91ab2d7cd011db47%7c1&sdata=IUZpWxvf1bu1x7Jb6UYLrdW10G6bMmvJ8Kl09%
>> 2fq0Mtk%3d
>>
>> This is a first step of refactoring, which includes cordova-lib
>> refactoring only.
>> The next steps once this PR will be reviewed and merged:
>> * Move shared code for platforms/cordova-lib into cordova-common
>> module
>> * Prepare and publish cordova-common (this also includes coho update)
>> * Switch cordova-lib to use cordova-common
>>
>> Brief overview of this PR:
>> It implements PlatformApiPoly class according to PlatformApi spec,
>> which allows to:
>> * create/update platform
>> * execute platform's actions (build/run/add/update)
>> * do a prepare (needed for CLI workflow only)
>> * install/uninstall plugins
>>
>> Other noticeable changes:
>> * removes `getPlatformProject` and PlatformProject method/class in
>> favor of PlatformApiPoly/getPlatformApi
>> * make assets and js-modules installing/uninstalling through ActionStack
>> * refactor configChanges to not require plugins_dir in constructor
>> * moves mergeXml helper to xml-helpers
>>
>> I would appreciate any feedback on this PR.
>> ------------------------
>> Best regards, Vladimir.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
> ТÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÐÐ¥FòVç7V'67&–&RÂRÖ֖âFWb×Vç7V'67&–&T6÷&F÷fæ6†Ræ÷&pФf÷"FF—F–öæÂ6öÖÖæG2ÂRÖ֖âFWbÖ†VÇ6÷&F÷fæ6†Ræ÷&pÐ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org