You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/05/03 14:54:16 UTC
[GitHub] [druid] techdocsmith commented on a diff in pull request #14202: Better actionable error message when druid services are not running
techdocsmith commented on code in PR #14202:
URL: https://github.com/apache/druid/pull/14202#discussion_r1183802426
##########
services/src/main/java/org/apache/druid/server/router/QueryHostFinder.java:
##########
@@ -99,14 +99,23 @@ public Server findServerSql(SqlQuery sqlQuery)
public <T> Server pickServer(Query<T> query)
{
Server server = findServer(query);
- assertServerFound(server, "No server found for query[%s]", query);
+ assertServerFound(
+ server,
+ "There are no brokers to connect to for query[%s]."
+ + "Please check that the brokers are "
+ + "running and are healthy.",
+ query
+ );
return server;
}
public Server pickDefaultServer()
{
Server server = findDefaultServer();
- assertServerFound(server, "No default server found!");
+ assertServerFound(
+ server,
+ "There are no brokers to connect to. Please check that the brokers are running and " + " are healthy."
Review Comment:
```suggestion
"There are no available brokers. Please check that the brokers are running and " + " healthy."
```
##########
services/src/main/java/org/apache/druid/server/router/QueryHostFinder.java:
##########
@@ -99,14 +99,23 @@ public Server findServerSql(SqlQuery sqlQuery)
public <T> Server pickServer(Query<T> query)
{
Server server = findServer(query);
- assertServerFound(server, "No server found for query[%s]", query);
+ assertServerFound(
+ server,
+ "There are no brokers to connect to for query[%s]."
Review Comment:
```suggestion
"There are no available brokers for query[%s]."
```
##########
services/src/main/java/org/apache/druid/server/router/QueryHostFinder.java:
##########
@@ -99,14 +99,23 @@ public Server findServerSql(SqlQuery sqlQuery)
public <T> Server pickServer(Query<T> query)
{
Server server = findServer(query);
- assertServerFound(server, "No server found for query[%s]", query);
+ assertServerFound(
+ server,
+ "There are no brokers to connect to for query[%s]."
+ + "Please check that the brokers are "
+ + "running and are healthy.",
Review Comment:
```suggestion
+ "running and healthy.",
```
##########
web-console/src/console-application.tsx:
##########
@@ -67,8 +67,9 @@ export class ConsoleApplication extends React.PureComponent<
timeout: 120000,
message: (
<>
- It appears that the service serving this console is not responding. The console will not
- function at the moment.
+ It appears that some backend druid services are not responding. The console will not
+ function at the moment. Please make sure that all the druid services are up and running.
Review Comment:
```suggestion
function at the moment. Make sure that all your Druid services are up and running.
```
##########
web-console/src/console-application.tsx:
##########
@@ -67,8 +67,9 @@ export class ConsoleApplication extends React.PureComponent<
timeout: 120000,
message: (
<>
- It appears that the service serving this console is not responding. The console will not
- function at the moment.
+ It appears that some backend druid services are not responding. The console will not
+ function at the moment. Please make sure that all the druid services are up and running.
+ You can look at the logs of individual services for troubleshooting.
Review Comment:
```suggestion
Check the logs of individual services for troubleshooting.
```
##########
web-console/src/console-application.tsx:
##########
@@ -67,8 +67,9 @@ export class ConsoleApplication extends React.PureComponent<
timeout: 120000,
message: (
<>
- It appears that the service serving this console is not responding. The console will not
- function at the moment.
+ It appears that some backend druid services are not responding. The console will not
Review Comment:
```suggestion
Some backend druid services are not responding. The console will not
```
##########
services/src/main/java/org/apache/druid/server/router/QueryHostFinder.java:
##########
@@ -99,14 +99,23 @@ public Server findServerSql(SqlQuery sqlQuery)
public <T> Server pickServer(Query<T> query)
{
Server server = findServer(query);
- assertServerFound(server, "No server found for query[%s]", query);
+ assertServerFound(
+ server,
+ "There are no brokers to connect to for query[%s]."
+ + "Please check that the brokers are "
Review Comment:
```suggestion
+ "Please check that you brokers are "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org