You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:12:24 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29061: [SPARK-32258][SQL] NormalizeFloatingNumbers can directly normalize on certain children expressions
HyukjinKwon commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r452585112
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
##########
@@ -91,5 +91,38 @@ class NormalizeFloatingPointNumbersSuite extends PlanTest {
comparePlans(doubleOptimized, correctAnswer)
}
+
+ test("normalize the children of If") {
Review comment:
nit: shall we put the JIRA id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org