You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/10/21 09:55:51 UTC
[kudu-CR] [fs] Fix possible overflow when calculate max open files
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14518
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
[fs] Fix possible overflow when calculate max_open_files
Originally, use `(rlimit*2)/5` to calculate its 40%, but when rlimit
is very large, `rlimit*2` may overflow, so we should change it
to `(rlimit/5)*2`
In addition, 40% of any value of the `uint64_t` type must be
less than `kint64max`, so there is no need to cap rlimit.
Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
---
M src/kudu/fs/block_manager.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14518/1
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
Patch Set 3:
> Patch Set 2:
>
> (1 comment)
Done
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 06:02:16 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14518
to look at the new patch set (#4).
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
[fs] Fix possible overflow when calculate max_open_files
Originally, use `(rlimit*2)/5` to calculate its 40%, but when rlimit
is very large, `rlimit*2` may overflow, so we should change it
to `(rlimit/5)*2`
Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
---
M src/kudu/fs/block_manager.cc
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14518/4
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
Patch Set 4: Verified+1 Code-Review+2
Overriding Jenkins, TSAN failure is unrelated to your patch.
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 17:12:23 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
Patch Set 4:
> Patch Set 4: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/19243/ : FAILURE
Can someone help me see why it fails?
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Oct 2019 07:24:13 +0000
Gerrit-HasComments: No
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14518
to look at the new patch set (#2).
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
[fs] Fix possible overflow when calculate max_open_files
Originally, use `(rlimit*2)/5` to calculate its 40%, but when rlimit
is very large, `rlimit*2` may overflow, so we should change it
to `(rlimit/5)*2`
In addition, 40% of any value of the `uint64_t` type must be
less than `kint64max`, so there is no need to cap rlimit.
Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
---
M src/kudu/fs/block_manager.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14518/2
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
[fs] Fix possible overflow when calculate max_open_files
Originally, use `(rlimit*2)/5` to calculate its 40%, but when rlimit
is very large, `rlimit*2` may overflow, so we should change it
to `(rlimit/5)*2`
Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Reviewed-on: http://gerrit.cloudera.org:8080/14518
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/block_manager.cc
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14518
to look at the new patch set (#3).
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
[fs] Fix possible overflow when calculate max_open_files
Originally, use `(rlimit*2)/5` to calculate its 40%, but when rlimit
is very large, `rlimit*2` may overflow, so we should change it
to `(rlimit/5)*2`
Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
---
M src/kudu/fs/block_manager.cc
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14518/3
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] Fix possible overflow when calculate max open files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14518 )
Change subject: [fs] Fix possible overflow when calculate max_open_files
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14518/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14518/2//COMMIT_MSG@13
PS2, Line 13: In addition, 40% of any value of the `uint64_t` type must be
: less than `kint64max`, so there is no need to cap rlimit.
I'd prefer you kept the cap, so that if someone adjusts the 40% in the future (to, say 60%) they won't accidentally introduce the possibility of an overflow.
--
To view, visit http://gerrit.cloudera.org:8080/14518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0426c303a1c16758c7274a308bc08d613d79e8
Gerrit-Change-Number: 14518
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Oct 2019 18:11:28 +0000
Gerrit-HasComments: Yes