You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/09 00:13:50 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24333: chore: remove deprecated api /superset/datasources
dpgaspar opened a new pull request, #24333:
URL: https://github.com/apache/superset/pull/24333
### SUMMARY
Removes old deprecated API `/superset/datasources/` use `/api/v1/dataset/` instead
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24333: chore: remove deprecated api /superset/datasources
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24333:
URL: https://github.com/apache/superset/pull/24333#discussion_r1224599577
##########
UPDATING.md:
##########
@@ -24,6 +24,7 @@ assists people when migrating to a new version.
## Next
+- [24333](https://github.com/apache/superset/pull/24333): Removed deprecated API `/superset/datasources`
Review Comment:
Could you move this to the Breaking Changes section and add the PR number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24333: chore: remove deprecated api /superset/datasources
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24333:
URL: https://github.com/apache/superset/pull/24333#issuecomment-1583661281
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24333](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ed13536) into [master](https://app.codecov.io/gh/apache/superset/commit/cab34c2dbf4a1030f4803be7fc87c054e1cbc92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cab34c2) will **decrease** coverage by `10.50%`.
> The diff coverage is `79.58%`.
> :exclamation: Current head ed13536 differs from pull request most recent head 51484cc. Consider uploading reports for the commit 51484cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #24333 +/- ##
===========================================
- Coverage 68.31% 57.82% -10.50%
===========================================
Files 1957 1905 -52
Lines 75624 74843 -781
Branches 8223 8108 -115
===========================================
- Hits 51664 43275 -8389
- Misses 21852 29456 +7604
- Partials 2108 2112 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.59% <65.33%> (+0.27%)` | :arrow_up: |
| python | `60.14% <80.00%> (-22.69%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.08% <78.66%> (+0.63%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...plugins/legacy-preset-chart-nvd3/src/Area/index.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0FyZWEvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Jhci9pbmRleC5qcw==) | `66.66% <ø> (ø)` | |
| [...gins/legacy-preset-chart-nvd3/src/DistBar/index.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Rpc3RCYXIvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [...plugins/legacy-preset-chart-nvd3/src/Line/index.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0xpbmUvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNWaXMuanM=) | `0.00% <0.00%> (ø)` | |
| [.../plugins/legacy-preset-chart-nvd3/src/Pie/index.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL1BpZS9pbmRleC5qcw==) | `33.33% <ø> (ø)` | |
| [...end/plugins/legacy-preset-chart-nvd3/src/preset.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3ByZXNldC5qcw==) | `0.00% <ø> (ø)` | |
| [...ins/legacy-preset-chart-nvd3/src/transformProps.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3RyYW5zZm9ybVByb3BzLmpz) | `7.40% <ø> (+0.74%)` | :arrow_up: |
| [...s/plugin-chart-pivot-table/src/PivotTableChart.tsx](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL1Bpdm90VGFibGVDaGFydC50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.43% <ø> (+2.77%)` | :arrow_up: |
| ... and [74 more](https://app.codecov.io/gh/apache/superset/pull/24333?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [288 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24333/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24333: chore: remove deprecated api /superset/datasources
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24333:
URL: https://github.com/apache/superset/pull/24333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org