[GitHub] [bookkeeper] eolivelli commented on a change in pull request #3046: Avoiding call fileChannelProvider init multiple times

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #3046:
URL: https://github.com/apache/bookkeeper/pull/3046#discussion_r806594846



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -731,6 +733,14 @@ public Journal(int journalIndex, File journalDirectory, ServerConfiguration conf
             LOG.debug("Last Log Mark : {}", lastLogMark.getCurMark());
         }
 
+        try {
+            this.fileChannelProvider = FileChannelProvider.newProvider(conf.getJournalChannelProvider());
+        } catch (IOException e) {
+            LOG.warn("Failed to initiate {}, use default fileSystem provider instead.",
+                conf.getJournalChannelProvider());
+            this.fileChannelProvider = new DefaultFileChannelProvider();

Review comment:
       We should fail the bookie, otherwise the system will not work as configured by the administrator




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org