You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/05/19 16:21:18 UTC
[PR] chore: improve PomSanitizer detection and robustness [camel]
gnodet opened a new pull request, #23332:
URL: https://github.com/apache/camel/pull/23332
## Summary
Improve `PomSanitizer` in `camel-jbang-mcp` to close detection gaps and simplify internals:
- **CDATA support**: values wrapped in `<![CDATA[...]]>` were previously invisible to detection — now inspected and masked
- **Camel placeholder recognition**: `{{vault:...}}` and `{{...}}` placeholders are preserved alongside Maven `${...}`
- **URL-embedded credentials**: new pattern detects `://user:password@host` in any element (catches JDBC URLs, HTTP basic auth in non-sensitive-named elements like `<db.url>`)
- **Additional keywords**: `connection-string`, `connectionstring`, `connection_string`
- **Single-pass processing**: merged the separate detection and masking regex passes into one
- **Minor cleanup**: `String.join` replaces `Collectors.joining`, removed unused import
12 new test cases covering all additions.
## Test plan
- [x] `mvn test -Dtest=PomSanitizerTest` — all 30 tests pass
- [ ] Verify no regressions in existing MCP tool behavior
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: improve PomSanitizer detection and robustness [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #23332:
URL: https://github.com/apache/camel/pull/23332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: improve PomSanitizer detection and robustness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23332:
URL: https://github.com/apache/camel/pull/23332#issuecomment-4491052699
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-mcp`
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `dsl/camel-jbang/camel-jbang-mcp`: 1 test(s) disabled on GitHub Actions
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26110325735)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: improve PomSanitizer detection and robustness [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23332:
URL: https://github.com/apache/camel/pull/23332#issuecomment-4490486318
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org