You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/28 18:06:06 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #17319: [improve][CI] Replace test reporting with less verbose solution
lhotari opened a new pull request, #17319:
URL: https://github.com/apache/pulsar/pull/17319
Fixes #16736
### Motivation
See #16736
This PR reduces noise in test reporting and removes the misleading check runs from PR checks.
### Modifications
- remove separate workflow that added GitHub Actions check runs
- replaces test reporting with https://github.com/mikepenz/action-junit-report which has been
copied to https://github.com/apache/pulsar-test-infra/tree/master/action-junit-report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1229942850
> Generally looks good. Thanks!
>
> Two comments:
>
> 1. `./.github/actions/merge-test-reports` seems no more references, we may remove it.
Yes makes sense.
> 2. I don't find a report on the new progress in the demo https://github.com/lhotari/pulsar/pull/78, can you show me a direct link for the test report page? (IIUC it should be something like this one: https://github.com/apache/pulsar/pull/17062/checks?check_run_id=8027361638)
The goal of the PR is to not add the report as a check run. The report is displayed on the workflow run summary page: https://github.com/lhotari/pulsar/actions/runs/2943996610
Besides the markdown report, annotations are added with the relevant code location and stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1229979065
One thing to remind here is that we may want to cherry-pick this change to previous release branch. I suppose we can possibly remove the test-reporter action from pulsar-test-infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1229738043
@tisonkun @maxsxu please join the review too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1230362438
@maxsxu I think @lhotari pushed a commit https://github.com/apache/pulsar-test-infra/commit/eeb9107170ddeb24f76b41bc0582e340c688113f directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1230276155
> One thing to remind here is that we may want to cherry-pick this change to previous release branch. I suppose we can possibly remove the test-reporter action from pulsar-test-infra.
>
> Or we can tag pulsar-test-infra and use a stable version :)
The forks of apache/pulsar still depend on test-reporter action and it might be a good idea to keep it for some time, also after our maintenance branches no more use it.
btw. There would be a way in GitHub Actions to make maintenance branches use workflows defined in the master branch. This is possible with the new reuseable workflows, https://github.blog/changelog/2022-08-22-github-actions-improvements-to-reusable-workflows-2/ . There's a tradeoff in doing this, but that could make things easier if we have a single pipeline to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17319:
URL: https://github.com/apache/pulsar/pull/17319#issuecomment-1230362782
> @maxsxu I think @lhotari pushed a commit [apache/pulsar-test-infra@eeb9107](https://github.com/apache/pulsar-test-infra/commit/eeb9107170ddeb24f76b41bc0582e340c688113f) directly.
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17319: [improve][CI] Replace test reporting with less verbose solution
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17319:
URL: https://github.com/apache/pulsar/pull/17319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org