You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by uncleGen <gi...@git.apache.org> on 2014/07/31 19:23:30 UTC

[GitHub] spark pull request: Spark Shuffle:use growth rate to predict if ...

GitHub user uncleGen opened a pull request:

    https://github.com/apache/spark/pull/1696

    Spark Shuffle:use growth rate to predict if need to spill

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uncleGen/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1696
    
----
commit 0afb53d61e3e6d57b8cfee5b91e8b29587775edb
Author: uncleGen <hu...@gmail.com>
Date:   2014-07-31T17:17:34Z

    Use growth rate to predict if need to spill

commit e458a301d439da7656bcdf1b81e22efc145a33e6
Author: uncleGen <hu...@gmail.com>
Date:   2014-07-31T17:20:28Z

    set  "spark.executor.cores"  for the executor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by uncleGen <gi...@git.apache.org>.
Github user uncleGen commented on the pull request:

    https://github.com/apache/spark/pull/1696#issuecomment-50958278
  
    @rxin Thanks for your attention, I have updated my jira. https://issues.apache.org/jira/browse/SPARK-2773


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1696


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1696#issuecomment-50790915
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/1696#issuecomment-50918791
  
    Thanks for submitting the pull request. Can you update the JIRA issue description to include more information, e.g. why this is needed, what kind of improvements did you see with this? 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/1696#issuecomment-54102692
  
    We fixed the issue with the listener in SPARK-2316 so I think we can close this issue for now. In normal operation we don't expect this queue to become unbounded. If you observe overflow in this queue please report it to the JIRA or developer list, it indicates a bug somewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-2773]use growth rate to predict if need...

Posted by uncleGen <gi...@git.apache.org>.
Github user uncleGen commented on the pull request:

    https://github.com/apache/spark/pull/1696#issuecomment-54102947
  
    @pwendell  OK!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org