You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/02/16 22:00:11 UTC
[GitHub] [libcloud] Kami opened a new pull request #1427: Ignore "[Errno 29]
Illegal seek" errors which may arise when using "upload_object_via_stream"
Kami opened a new pull request #1427: Ignore "[Errno 29] Illegal seek" errors which may arise when using "upload_object_via_stream"
URL: https://github.com/apache/libcloud/pull/1427
This pull request updates ``upload_object_via_stream`` method so any ``[Errno 29] Illegal seek`` error which is thrown by the ``_hash_buffered_stream`` function is ignored.
## Background
It looks like this regression has been inadvertently introduced in 4053779e700e8674856876ee85e6ac954cf2df14 (#1326 - cc @gvengel - just a heads up).
Some iterators such as PIPEs don't support seeking and in such case ``[Errno 29] Illegal seek`` exception is thrown.
In this context such exception is harmless so we should ignore it and proceed with hashing - this change does just that.
Thanks to @perbu for reporting this issue.
Closes #1424.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1427: Ignore "[Errno 29]
Illegal seek" errors which may arise when using "upload_object_via_stream"
method
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1427: Ignore "[Errno 29] Illegal seek" errors which may arise when using "upload_object_via_stream" method
URL: https://github.com/apache/libcloud/pull/1427#issuecomment-586759736
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=h1) Report
> Merging [#1427](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/9e51fc06e79a32f43d513d815b12e8a8f834d269?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1427 +/- ##
==========================================
+ Coverage 86.08% 86.09% +<.01%
==========================================
Files 370 370
Lines 77507 77533 +26
Branches 7655 7656 +1
==========================================
+ Hits 66724 66751 +27
+ Misses 7884 7883 -1
Partials 2899 2899
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/test/storage/test\_base.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfYmFzZS5weQ==) | `94.21% <100%> (+1.28%)` | :arrow_up: |
| [libcloud/storage/base.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9iYXNlLnB5) | `82.45% <100%> (+0.42%)` | :arrow_up: |
| [libcloud/test/\_\_init\_\_.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9fX2luaXRfXy5weQ==) | `87.06% <0%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=footer). Last update [9e51fc0...00e431f](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1427: Ignore
"[Errno 29] Illegal seek" errors which may arise when using
"upload_object_via_stream" method
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1427: Ignore "[Errno 29] Illegal seek" errors which may arise when using "upload_object_via_stream" method
URL: https://github.com/apache/libcloud/pull/1427#issuecomment-586759736
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=h1) Report
> Merging [#1427](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/9e51fc06e79a32f43d513d815b12e8a8f834d269?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1427 +/- ##
==========================================
+ Coverage 86.08% 86.09% +<.01%
==========================================
Files 370 370
Lines 77507 77531 +24
Branches 7655 7656 +1
==========================================
+ Hits 66724 66749 +25
+ Misses 7884 7883 -1
Partials 2899 2899
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/test/storage/test\_base.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfYmFzZS5weQ==) | `94.11% <100%> (+1.18%)` | :arrow_up: |
| [libcloud/storage/base.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9iYXNlLnB5) | `82.45% <100%> (+0.42%)` | :arrow_up: |
| [libcloud/test/\_\_init\_\_.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9fX2luaXRfXy5weQ==) | `87.06% <0%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=footer). Last update [9e51fc0...00e431f](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1427: Ignore
"[Errno 29] Illegal seek" errors which may arise when using
"upload_object_via_stream" method
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1427: Ignore "[Errno 29] Illegal seek" errors which may arise when using "upload_object_via_stream" method
URL: https://github.com/apache/libcloud/pull/1427#issuecomment-586759736
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=h1) Report
> Merging [#1427](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/00e431fd4ad0feef73d0620fe1f7c58c101067ee?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1427 +/- ##
==========================================
+ Coverage 86.09% 86.09% +<.01%
==========================================
Files 370 370
Lines 77531 77538 +7
Branches 7656 7657 +1
==========================================
+ Hits 66749 66756 +7
Misses 7883 7883
Partials 2899 2899
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/dns/drivers/cloudflare.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvZG5zL2RyaXZlcnMvY2xvdWRmbGFyZS5weQ==) | `95.18% <ø> (ø)` | :arrow_up: |
| [libcloud/test/dns/test\_cloudflare.py](https://codecov.io/gh/apache/libcloud/pull/1427/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9kbnMvdGVzdF9jbG91ZGZsYXJlLnB5) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=footer). Last update [00e431f...a7b24c4](https://codecov.io/gh/apache/libcloud/pull/1427?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1427: Ignore "[Errno 29]
Illegal seek" errors which may arise when using "upload_object_via_stream"
method
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1427: Ignore "[Errno 29] Illegal seek" errors which may arise when using "upload_object_via_stream" method
URL: https://github.com/apache/libcloud/pull/1427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services