You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by hsaputra <gi...@git.apache.org> on 2015/06/18 20:46:09 UTC
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/44
Simple change to add missing Javadoc to class header and public method.
Another simple PR to add missing Javadoc to class header and public method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill add_javadoc_to_zkclients_class
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 04d82f95c77548bf3d2ff25e59fb7ac6bd27e12b
Author: hsaputra <hs...@apache.org>
Date: 2015-06-18T18:45:05Z
Simple change to add missing Javadoc to class header and public method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/44#issuecomment-114254066
Please rebase to one commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/44#issuecomment-114259929
Thanks, just rebased into one commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-twill/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/44#discussion_r32765037
--- Diff: twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKClients.java ---
@@ -51,7 +51,13 @@ public static ZKClient retryOnFailure(ZKClient client, RetryStrategy retryStrate
return new FailureRetryZKClient(client, retryStrategy);
}
-
+ /**
+ * Creates a {@link ZKClient} that will add prefix namespace for every paths.
+ *
+ * @param zkClient The {@link ZKClient} for operations delegation.
+ * @param namespace The prefix namespace to be appended to paths.
--- End diff --
Isn't it better to use prepend instead of append here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on the pull request:
https://github.com/apache/incubator-twill/pull/44#issuecomment-113256406
Two minor comments, otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/44#discussion_r32764931
--- Diff: twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKClients.java ---
@@ -51,7 +51,13 @@ public static ZKClient retryOnFailure(ZKClient client, RetryStrategy retryStrate
return new FailureRetryZKClient(client, retryStrategy);
}
-
+ /**
+ * Creates a {@link ZKClient} that will add prefix namespace for every paths.
+ *
+ * @param zkClient The {@link ZKClient} for operations delegation.
+ * @param namespace The prefix namespace to be appended to paths.
+ * @return
--- End diff --
Empty return tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Simple change to add missing Javadoc...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/44#issuecomment-113258244
Thanks @poornachandra , just updated PR based on review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---