You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/06 05:46:07 UTC

[GitHub] [flink] danny0405 opened a new pull request #10096: [FLINK-14623][table-api] Add computed column information into TableSc…

danny0405 opened a new pull request #10096: [FLINK-14623][table-api] Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096
 
 
   …hema
   
   ## What is the purpose of the change
   
   This patch add computed column info into the `TableSchema`, also fix some tests of computed column syntax test.
   
   
   ## Brief change log
   
     - Add a new structure `TableColumn` to column the table column info: name, type, and expression
     - Add se/de for the computed column expression
     - Some refactoring to the `TableSchema` to move the fields validation logic into the `Builder`
   
   ## Verifying this change
   
   See tests in `FlinkSqlParserImplTest`, `TableSchemaTest` and `DescriptorPropertiesTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services