[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #4592: Nessie: Replace CommitStateUnknownException with CommitFailedException

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #4592:
URL: https://github.com/apache/iceberg/pull/4592#discussion_r854097154


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -274,12 +273,9 @@ public void renameTable(TableIdentifier from, TableIdentifier to) {
       // to catch all kinds of network errors (e.g. connection reset). Network code implementation
       // details and all kinds of network devices can induce unexpected behavior. So better be
       // safe than sorry.
-      throw new CommitStateUnknownException(ex);
+      throw new CommitFailedException(ex, "Cannot rename table '%s' to '%s': " +

Review Comment:
   I'm not sure this is right, I think this was originally added because some of the exceptions here do happen when the commit succeeded on the server but it failed to propagate the ack back to the client. At least that's what I was told when this got added way back when. If things have changed let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org