[jira] [Commented] (NIFI-3109) Refactor TimerDrivenSchedulingAgent

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706401#comment-15706401 ] 

ASF GitHub Bot commented on NIFI-3109:
--------------------------------------

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/1280

    NIFI-3109 Initial refactoring of TimerDrivenSchedulingAgent

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    - moved ‘continuallyRunTask’ creation outside of the loop
    - created a single instance of Runnable delegate for ‘continuallyRunTask' to be used by all tasks
    - simplified scheduling logic inside of the Runnable

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-3109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1280
    
----

----


> Refactor TimerDrivenSchedulingAgent
> -----------------------------------
>
>                 Key: NIFI-3109
>                 URL: https://issues.apache.org/jira/browse/NIFI-3109
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core Framework
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> While working on determining reasons for bug described in NIFI-2886, I've noticed an opportunity for some refactoring which in a way is significant as it greatly reduces the code base, eliminates unnecessary synchronization as well as provides for better reusability of object instances. (i.e., Currently for each task an instance of ContinuallyRunProcessorTask is created while the same instance could be reused for all tasks, and more)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)