You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/05 23:33:02 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

dongjoon-hyun commented on a change in pull request #30264:
URL: https://github.com/apache/spark/pull/30264#discussion_r518434104



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -248,6 +248,68 @@ abstract class DataSourceV2AnalysisBaseSuite extends AnalysisTest {
 
   def byPosition(table: NamedRelation, query: LogicalPlan): LogicalPlan
 
+  test("SPARK-33136: output resolved on complex types for V2 write commands") {

Review comment:
       Is this adding a test case for SPARK-33136 in the PR for SPARK-33360, @cloud-fan ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org