[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #154: [feat] Support partitioned topic reader.

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #154:
URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1062317982


##########
include/pulsar/ConsumerConfiguration.h:
##########
@@ -383,6 +383,26 @@ class PULSAR_PUBLIC ConsumerConfiguration {
      */
     InitialPosition getSubscriptionInitialPosition() const;
 
+    /**
+     * Selects the subscription mode to be used when subscribing to a topic.
+     *
+     * <p>Options are:
+     * <ul>
+     *  <li>{@link SubscriptionMode#Durable} (Default)</li>
+     *  <li>{@link SubscriptionMode#NonDurable}</li>
+     * </ul>
+     *
+     * @param subscriptionMode the subscription mode value
+     */
+    ConsumerConfiguration& setSubscriptionMode(SubscriptionMode subscriptionMode);
+
+    /**
+     * Get subscription mode.
+     *
+     * @return
+     */
+    SubscriptionMode getSubscriptionMode() const;

Review Comment:
   It's better not support setting the subscription mode. /cc @codelipenghui 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org