You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/16 06:46:09 UTC
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1109: [KYUUBI #1105] Zorder codegen support
yaooqinn commented on a change in pull request #1109:
URL: https://github.com/apache/incubator-kyuubi/pull/1109#discussion_r709824830
##########
File path: dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/zorder/Zorder.scala
##########
@@ -42,21 +46,61 @@ case class Zorder(children: Seq[Expression]) extends Expression with CodegenFall
}
@transient
- private lazy val defaultNullValues: Seq[Any] = {
- children.map(child => ZorderBytesUtils.defaultValue(child.dataType))
+ private lazy val defaultNullValues: JMap[Int, Array[Byte]] = {
Review comment:
Using idx as a key seems not necessary? we can use an arrary/seq here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org