You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/12/07 09:04:00 UTC
[jira] [Work logged] (ARTEMIS-3601) Expose acceptors via management
[ https://issues.apache.org/jira/browse/ARTEMIS-3601?focusedWorklogId=691574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-691574 ]
ASF GitHub Bot logged work on ARTEMIS-3601:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/21 09:03
Start Date: 07/Dec/21 09:03
Worklog Time Spent: 10m
Work Description: brusdev commented on a change in pull request #3873:
URL: https://github.com/apache/activemq-artemis/pull/3873#discussion_r763776474
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -2764,6 +2764,35 @@ private JsonObject toJSONObject(ServerConsumer consumer) throws Exception {
}
}
+ @Override
+ public Object[] getAcceptors() throws Exception {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.getAcceptors(this.server);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ Collection<TransportConfiguration> acceptorConfigurations = configuration.getAcceptorConfigurations();
+
+ Object[] ret = new Object[acceptorConfigurations.size()];
+
+ int i = 0;
+ for (TransportConfiguration config : acceptorConfigurations) {
Review comment:
this code is very similar to the code of `getConnectors`, is it possible avoiding this code duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 691574)
Remaining Estimate: 0h
Time Spent: 10m
> Expose acceptors via management
> -------------------------------
>
> Key: ARTEMIS-3601
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3601
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)