You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/17 10:36:18 UTC

[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #42: Separate docker build files

lujiajing1126 commented on pull request #42:
URL: https://github.com/apache/skywalking-banyandb/pull/42#issuecomment-900183760


   > Also, separating the `publish-docker` workflow into 2 files makes no sense IMO, the reason why we want the workflow to run (partially though) in PRs is that we want to check the commands in that workflow is runnable and don't want it to break after merging. Separating it into 2 files may lead to a situation where developers adjust the file `.github/workflows/publish-docker-pr.yml` to make the CI pass and merge the PRs, but forget to adjust `.github/workflows/publish-docker-main.yml`.
   
   This change has been reverted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org