You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "James Casey (JIRA)" <ji...@apache.org> on 2010/05/07 17:15:48 UTC
[jira] Created: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
init.d script fails if RUN_AS_GROUP not defined due to typo
-----------------------------------------------------------
Key: AMQ-2726
URL: https://issues.apache.org/activemq/browse/AMQ-2726
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Environment: activemq trunk, RHEL5
Reporter: James Casey
Priority: Trivial
Attachments: run-as-group.patch
In the supplied init.d scripts for linux there is a typo
{{RUN_AS_GROUP=RUN_AS_USER}}
which should be
{{RUN_AS_GROUP=$RUN_AS_USER}}
Looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen:
{code}
RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
if [ "X$RUN_AS_GROUP" = "X" ]
then
RUN_AS_GROUP=RUN_AS_USER
fi
{code}
Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully resolved AMQ-2726.
-----------------------------
Fix Version/s: 5.4.0
Resolution: Fixed
patch applied with thanks in r945032
> init.d script fails if RUN_AS_GROUP not defined due to typo
> -----------------------------------------------------------
>
> Key: AMQ-2726
> URL: https://issues.apache.org/activemq/browse/AMQ-2726
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Environment: activemq trunk, RHEL5
> Reporter: James Casey
> Assignee: Gary Tully
> Priority: Trivial
> Fix For: 5.4.0
>
> Attachments: run-as-group-macosx.patch, run-as-group.patch
>
>
> In the supplied init.d scripts for linux there is a typo
> {{RUN_AS_GROUP=RUN_AS_USER}}
> which should be
> {{RUN_AS_GROUP=$RUN_AS_USER}}
> We have this in our patches on our production server so we must have hit the problem at some point, but looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen on a well-configured mahcine:
> {code}
> RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
> if [ "X$RUN_AS_GROUP" = "X" ]
> then
> RUN_AS_GROUP=RUN_AS_USER
> fi
> {code}
> Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
Posted by "James Casey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Casey updated AMQ-2726:
-----------------------------
Description:
In the supplied init.d scripts for linux there is a typo
{{RUN_AS_GROUP=RUN_AS_USER}}
which should be
{{RUN_AS_GROUP=$RUN_AS_USER}}
We have this in our patches on our production server so we must have hit the problem at some point, but looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen on a well-configured mahcine:
{code}
RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
if [ "X$RUN_AS_GROUP" = "X" ]
then
RUN_AS_GROUP=RUN_AS_USER
fi
{code}
Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
was:
In the supplied init.d scripts for linux there is a typo
{{RUN_AS_GROUP=RUN_AS_USER}}
which should be
{{RUN_AS_GROUP=$RUN_AS_USER}}
Looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen:
{code}
RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
if [ "X$RUN_AS_GROUP" = "X" ]
then
RUN_AS_GROUP=RUN_AS_USER
fi
{code}
Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
> init.d script fails if RUN_AS_GROUP not defined due to typo
> -----------------------------------------------------------
>
> Key: AMQ-2726
> URL: https://issues.apache.org/activemq/browse/AMQ-2726
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Environment: activemq trunk, RHEL5
> Reporter: James Casey
> Priority: Trivial
> Attachments: run-as-group.patch
>
>
> In the supplied init.d scripts for linux there is a typo
> {{RUN_AS_GROUP=RUN_AS_USER}}
> which should be
> {{RUN_AS_GROUP=$RUN_AS_USER}}
> We have this in our patches on our production server so we must have hit the problem at some point, but looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen on a well-configured mahcine:
> {code}
> RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
> if [ "X$RUN_AS_GROUP" = "X" ]
> then
> RUN_AS_GROUP=RUN_AS_USER
> fi
> {code}
> Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully reassigned AMQ-2726:
-------------------------------
Assignee: Gary Tully
> init.d script fails if RUN_AS_GROUP not defined due to typo
> -----------------------------------------------------------
>
> Key: AMQ-2726
> URL: https://issues.apache.org/activemq/browse/AMQ-2726
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Environment: activemq trunk, RHEL5
> Reporter: James Casey
> Assignee: Gary Tully
> Priority: Trivial
> Attachments: run-as-group-macosx.patch, run-as-group.patch
>
>
> In the supplied init.d scripts for linux there is a typo
> {{RUN_AS_GROUP=RUN_AS_USER}}
> which should be
> {{RUN_AS_GROUP=$RUN_AS_USER}}
> We have this in our patches on our production server so we must have hit the problem at some point, but looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen on a well-configured mahcine:
> {code}
> RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
> if [ "X$RUN_AS_GROUP" = "X" ]
> then
> RUN_AS_GROUP=RUN_AS_USER
> fi
> {code}
> Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
Posted by "James Casey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Casey updated AMQ-2726:
-----------------------------
Attachment: run-as-group-macosx.patch
looks like the macosx script has the same problem
> init.d script fails if RUN_AS_GROUP not defined due to typo
> -----------------------------------------------------------
>
> Key: AMQ-2726
> URL: https://issues.apache.org/activemq/browse/AMQ-2726
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Environment: activemq trunk, RHEL5
> Reporter: James Casey
> Priority: Trivial
> Attachments: run-as-group-macosx.patch, run-as-group.patch
>
>
> In the supplied init.d scripts for linux there is a typo
> {{RUN_AS_GROUP=RUN_AS_USER}}
> which should be
> {{RUN_AS_GROUP=$RUN_AS_USER}}
> We have this in our patches on our production server so we must have hit the problem at some point, but looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen on a well-configured mahcine:
> {code}
> RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
> if [ "X$RUN_AS_GROUP" = "X" ]
> then
> RUN_AS_GROUP=RUN_AS_USER
> fi
> {code}
> Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-2726) init.d script fails if RUN_AS_GROUP not
defined due to typo
Posted by "James Casey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Casey updated AMQ-2726:
-----------------------------
Attachment: run-as-group.patch
> init.d script fails if RUN_AS_GROUP not defined due to typo
> -----------------------------------------------------------
>
> Key: AMQ-2726
> URL: https://issues.apache.org/activemq/browse/AMQ-2726
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Environment: activemq trunk, RHEL5
> Reporter: James Casey
> Priority: Trivial
> Attachments: run-as-group.patch
>
>
> In the supplied init.d scripts for linux there is a typo
> {{RUN_AS_GROUP=RUN_AS_USER}}
> which should be
> {{RUN_AS_GROUP=$RUN_AS_USER}}
> Looking at the code it's not even clear the case that this code would be called (RUN_AS_USER set to a user which does not have a primary group) could ever happen:
> {code}
> RUN_AS_GROUP=`groups $RUN_AS_USER | awk '{print $3}' | tail -1`
> if [ "X$RUN_AS_GROUP" = "X" ]
> then
> RUN_AS_GROUP=RUN_AS_USER
> fi
> {code}
> Patch attached to do the change above, but perhaps the whole IF statement should be deleted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.