You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2012/06/23 14:01:12 UTC
svn commit: r1353115 -
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java
Author: tn
Date: Sat Jun 23 12:01:11 2012
New Revision: 1353115
URL: http://svn.apache.org/viewvc?rev=1353115&view=rev
Log:
[COLLECTIONS-413] Improve performance of DualBidiMap#removeAll. Thanks to Adrian Nistor for report and patch.
Modified:
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java?rev=1353115&r1=1353114&r2=1353115&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java Sat Jun 23 12:01:11 2012
@@ -346,12 +346,9 @@ public abstract class AbstractDualBidiMa
return false;
}
boolean modified = false;
- Iterator<E> it = iterator();
+ final Iterator<?> it = coll.iterator();
while (it.hasNext()) {
- if (coll.contains(it.next())) {
- it.remove();
- modified = true;
- }
+ modified |= remove(it.next());
}
return modified;
}