You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/10 18:11:37 UTC

[GitHub] michellethomas commented on a change in pull request #6069: Cypress tests for controls and explore links

michellethomas commented on a change in pull request #6069: Cypress tests for controls and explore links
URL: https://github.com/apache/incubator-superset/pull/6069#discussion_r224185805
 
 

 ##########
 File path: superset/assets/src/explore/components/ControlHeader.jsx
 ##########
 @@ -63,6 +65,7 @@ export default class ControlHeader extends React.Component {
     return (
       <div
         className="ControlHeader"
+        data-test={`${this.props.name}-header`}
 
 Review comment:
   I added this for annotations because I couldn't find another way to distinguish the controls in annotations from one another. The rest of controls use the `Controls` component (which has data-test already set) but annotations just use the controls themselves. If anyone is familiar with annotations and has another idea for identifying the controls let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org