You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/09/26 13:03:28 UTC
[GitHub] flink pull request #2548: [FLINK-4677] fail if user jar contains no executio...
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2548
[FLINK-4677] fail if user jar contains no executions
If the user has an empty main method with no Flink executions, this will print a nicer error message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-4677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2548
----
commit 55f8ff766674b7c112a364de287b30a7afa4a1ee
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-09-26T13:00:32Z
[FLINK-4677] fail if user jar contains no executions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2548: [FLINK-4677] fail if user jar contains no executions
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2548
Do we have a standard way for user programs to print usage and exit without triggering this message? This is certainly preferable to the `NullPointerException`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2548: [FLINK-4677] fail if user jar contains no executio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2548: [FLINK-4677] fail if user jar contains no executions
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2548
Looks good to me, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2548: [FLINK-4677] fail if user jar contains no executions
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2548
That's a good point @greghogan. We don't have a standard way to print a usage message. A disadvantage of the approach in this PR is that we will display an error message which might actually mask any usage information printed. An alternative approach would be to simply exit (perhaps with a small hint). That might actually be nicer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---