You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2013/02/01 12:52:56 UTC
Review Request: [EC2 Query API] AssociateAdress,
DisassociateAddress and ReleaseAddress fail with NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9253/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
When invalid parameter is provided as input for any of these API's we get an NPE
This addresses bug CLOUDSTACK-1136.
Diffs
-----
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af
Diff: https://reviews.apache.org/r/9253/diff/
Testing
-------
Run each of these 3 API for e.g. ec2_release_address with an invalid public ip address - throws Server.Internal error
Thanks,
Likitha Shetty
Re: Review Request: [EC2 Query API] AssociateAdress,
DisassociateAddress and ReleaseAddress fail with NPE
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9253/#review16441
-----------------------------------------------------------
Ship it!
Fix is Ok. Commit hash: 0b43efbcbf34ccd0a5a362b18fab3670384a239d
- Prachi Damle
On Feb. 1, 2013, 11:52 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9253/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 11:52 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> When invalid parameter is provided as input for any of these API's we get an NPE
>
>
> This addresses bug CLOUDSTACK-1136.
>
>
> Diffs
> -----
>
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af
>
> Diff: https://reviews.apache.org/r/9253/diff/
>
>
> Testing
> -------
>
> Run each of these 3 API for e.g. ec2_release_address with an invalid public ip address - throws Server.Internal error
>
>
> Thanks,
>
> Likitha Shetty
>
>