You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@karaf.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2012/05/23 16:16:41 UTC

[jira] [Comment Edited] (KARAF-710) Refactor org.apache.karaf.shell.console.commands.GenericType

    [ https://issues.apache.org/jira/browse/KARAF-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281621#comment-13281621 ] 

Guillaume Nodet edited comment on KARAF-710 at 5/23/12 2:14 PM:
----------------------------------------------------------------

The original reason for duplicating this class is that the annotations for commands were in gogo and not tied to blueprint, so instead of adding a unneeded dependency to the blueprint API, I chose to copy the class.  
But I think it can be safely revisit given those annotations have moved to Karaf and Karaf actually depends on Blueprint.
However, if we do, we need to use the blueprint one, not a different one, because the commands usually reuse the blueprint converter from the blueprint context.
                
      was (Author: gnt):
    The original reason for duplicating this class is that the annotations for commands were in gogo and not tied to blueprint, so instead of adding a unneeded dependency to the blueprint API, I chose to copy the class.  
But I think it can be safely revisit given those annotations have moved to Karaf and Karaf actually depends on Blueprint.
                  
> Refactor org.apache.karaf.shell.console.commands.GenericType
> ------------------------------------------------------------
>
>                 Key: KARAF-710
>                 URL: https://issues.apache.org/jira/browse/KARAF-710
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-shell
>            Reporter: Jamie goodyear
>             Fix For: 3.1.0
>
>
> There are two GenericType classes available: 
> org.apache.karaf.shell.console.commands.GenericType
> org.apache.felix.gogo.commands.converter.GenericType
> We should review if we need to duplicate the class offered by GoGo in Karaf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira