You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/06/24 03:25:55 UTC

[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #269: fix not unpack ref holder for list

wongoo commented on a change in pull request #269:
URL: https://github.com/apache/dubbo-go-hessian2/pull/269#discussion_r657597619



##########
File path: codec.go
##########
@@ -422,9 +415,21 @@ func SetSlice(dest reflect.Value, objects interface{}) error {
 	return nil
 }
 
+// unpackRefHolder unpack the ref holder when decoding slice finished.

Review comment:
       I think should use do not does.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org