You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/15 21:49:28 UTC

[GitHub] [flink] syhily opened a new pull request, #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

syhily opened a new pull request, #19977:
URL: https://github.com/apache/flink/pull/19977

   ## What is the purpose of the change
   
   Pulsar unordered reader is used for Shared and Key_Shared subscriptions. It would reconsume a message if it didn't acknowledge in a transaction. But this didn't works now. Because we don't use Pulsar's Multiple consumer. The best way to solve this problem is just delete this reconsumeLater logic.
   
   ## Brief change log
   
   Delete the reconsumeLater when meeting exceptions in acknowledge.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily closed pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

Posted by GitBox <gi...@apache.org>.
syhily closed pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.
URL: https://github.com/apache/flink/pull/19977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] imaffe commented on pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

Posted by GitBox <gi...@apache.org>.
imaffe commented on PR #19977:
URL: https://github.com/apache/flink/pull/19977#issuecomment-1157163612

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19977: [FLINK-28084][Connector/Pulsar] Remove the reconsume later logic for Pulsar unordered reader.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19977:
URL: https://github.com/apache/flink/pull/19977#issuecomment-1156981879

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9756d018cd49ff6b7f3f6f1a46e5dd1b6cc4aaa4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9756d018cd49ff6b7f3f6f1a46e5dd1b6cc4aaa4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9756d018cd49ff6b7f3f6f1a46e5dd1b6cc4aaa4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org