You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/12/18 23:55:25 UTC

[GitHub] [geode] PurelyApplied opened pull request #3020: Anternative fix for CI to #3018

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3020 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dickcav closed pull request #3020: Anternative fix for CI to #3018

Posted by "dickcav (GitHub)" <gi...@apache.org>.
[ pull request closed by dickcav ]

[ Full content available at: https://github.com/apache/geode/pull/3020 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3020: Anternative fix for CI to #3018

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
The version change in the expected pom is unnecessary, because version strings are ignored, but I think it would be good to keep them up-to-date in any case.

By applying the `geode-dependency-management` plugin at the root project, all top-level tasks, including but not limited to the `resolveDependencies` task, will depend on the local publication of the BOM, as intended.

[ Full content available at: https://github.com/apache/geode/pull/3020 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3020: Anternative fix for CI to #3018

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Apparently I have to comment in a comment and not the commit message to link to #3018 

[ Full content available at: https://github.com/apache/geode/pull/3020 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org