You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Nathan Bubna (JIRA)" <de...@velocity.apache.org> on 2011/01/28 17:45:44 UTC
[jira] Created: (VELOCITY-797) Inline macros need to be kept with
their Template, not centrally managed
Inline macros need to be kept with their Template, not centrally managed
------------------------------------------------------------------------
Key: VELOCITY-797
URL: https://issues.apache.org/jira/browse/VELOCITY-797
Project: Velocity
Issue Type: Bug
Components: Engine
Affects Versions: 1.7
Reporter: Nathan Bubna
Fix For: 2.x
This is the proper fix required by VELOCITY-776. Centrally managed inline macros cause race conditions whenever templates are not cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] [Commented] (VELOCITY-797) Inline macros need to be kept
with their Template, not centrally managed
Posted by "Nathan Bubna (Commented) (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230731#comment-13230731 ]
Nathan Bubna commented on VELOCITY-797:
---------------------------------------
Awesome! Jarkko, any chance you want to accept the offer to be a committer from several years ago? Then you could commit these yourself. :)
> Inline macros need to be kept with their Template, not centrally managed
> ------------------------------------------------------------------------
>
> Key: VELOCITY-797
> URL: https://issues.apache.org/jira/browse/VELOCITY-797
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.7
> Reporter: Nathan Bubna
> Fix For: 2.x
>
> Attachments: VELOCITY-797.patch
>
>
> This is the proper fix required by VELOCITY-776. Centrally managed inline macros cause race conditions whenever templates are not cached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] [Updated] (VELOCITY-797) Inline macros need to be kept with
their Template, not centrally managed
Posted by "Jarkko Viinamäki (Updated JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarkko Viinamäki updated VELOCITY-797:
--------------------------------------
Attachment: VELOCITY-797.patch
Here's a patch for Velocity 2.0 trunk which implements the change Nathan described i.e. macros are not stored centrally but rather kept within templates. It fixes VELOCITY-776.
This patch also improves pom.xml to hook JavaCC plugin automatically to the build process, removes a lot of unnecessary code, adds new test cases etc. There are also several internal interface changes (should not affect any Velocity users though).
All tests pass but these rather radical changes have not been tested otherwise. Careful review is needed.
> Inline macros need to be kept with their Template, not centrally managed
> ------------------------------------------------------------------------
>
> Key: VELOCITY-797
> URL: https://issues.apache.org/jira/browse/VELOCITY-797
> Project: Velocity
> Issue Type: Bug
> Components: Engine
> Affects Versions: 1.7
> Reporter: Nathan Bubna
> Fix For: 2.x
>
> Attachments: VELOCITY-797.patch
>
>
> This is the proper fix required by VELOCITY-776. Centrally managed inline macros cause race conditions whenever templates are not cached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org