[GitHub] [flink] zhuzhurk commented on a change in pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

[GitBox <gi...@apache.org>]

zhuzhurk commented on a change in pull request #18130:
URL: https://github.com/apache/flink/pull/18130#discussion_r784676712



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
##########
@@ -54,6 +54,8 @@
 
     protected final ResultPartitionID partitionId;
 
+    protected final int subpartitionIdx;

Review comment:
       I would propose to rename it to  `consumedSubpartitionIndex` and also replace all other `subpartitionIdx` in this PR

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateFactory.java
##########
@@ -173,20 +177,35 @@ private void createInputChannels(
             String owningTaskName,
             InputGateDeploymentDescriptor inputGateDeploymentDescriptor,
             SingleInputGate inputGate,
+            InputGateDeploymentDescriptor.SubpartitionIndexRange subpartitionRange,
             InputChannelMetrics metrics) {
         ShuffleDescriptor[] shuffleDescriptors =
                 inputGateDeploymentDescriptor.getShuffleDescriptors();
 
         // Create the input channels. There is one input channel for each consumed partition.

Review comment:
       the comment is outdated. I think it should be "... for each consumed sub-partition."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org